feat: close rpc connections when not in use #6646
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 2 files 86 suites 25m 27s ⏱️ Results for commit 3730921. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests)0 tests 0 ✅ 0s ⏱️ Results for commit 3730921. ♻️ This comment has been updated with latest results. |
hansieodendaal
force-pushed
the
ho_rpc_sessions
branch
2 times, most recently
from
3271d0a to
22f13c5
Compare
hansieodendaal
force-pushed
the
ho_rpc_sessions
branch
from
22f13c5 to
8ccf31d
Compare
Added the ability to close RPC connections for a given peer: - When dialing a peer (in establishing a new connection), a drop old connections switch can be included in the dial request from the client so that only only one RPC client connection will ever be active.
hansieodendaal
force-pushed
the
ho_rpc_sessions
branch
from
8ccf31d to
3730921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the ability to close RPC connections for a given peer:
Motivation and Context
Wallets keep on hitting their maximum allowed RPC sessions in the server.
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Code review
Breaking Changes