Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): sync templates when syncing substates #1242

Open
wants to merge 8 commits into
base: development
Choose a base branch
from

Conversation

ksrichard
Copy link
Collaborator

Description

Synchronizing when a VN is just added to the network or syncing new substates. We try to fetch template binary from its owning committee to make our chance higher to get it.
There is also a logic put to periodically check for pending templates, so if we know that we must have a template ready, just try to fetch again from other VNs.

Motivation and Context

When new nodes are joining the network, they did not have the template binaries as so we needed synchronization.

How Has This Been Tested?

  1. Start a local swarm with X VNs
  2. Publishing a new template (via CLI is simpler)
  3. Adding a new VN (or more)
  4. Mine to next epoch to make VN(s) available
  5. See if new VN(s) have the new template already registered

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

Copy link

github-actions bot commented Jan 15, 2025

Test Results (CI)

585 tests  +585   585 ✅ +585   1h 25m 27s ⏱️ + 1h 25m 27s
 54 suites + 54     0 💤 ±  0 
  1 files   ±  0     0 ❌ ±  0 

Results for commit 1b89ea6. ± Comparison against base commit 953b976.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants