Fix for MariaDB Compatibility with ST_SRID Function #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ueries based on database drivers.
deligoez
approved these changes
Nov 27, 2024
frkcn
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue reported in #31 where MariaDB does not support the second parameter for the ST_SRID() function, as documented here.
The issue caused errors like the following when using the package with Laravel’s MariaDB driver:
Changes Made:
ST_SRID()to exclude the second parameter when the connection is identified as MariaDB.HasSpatialtrait.Impact:
This fix resolves compatibility issues with MariaDB and ensures the package functions seamlessly for users relying on MariaDB drivers.
Thank you @jangaraev for your feedback and for highlighting this issue! Your support and use of the package are greatly appreciated.