ci: fix ci #96
Merged
ci: fix ci #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdzzz
force-pushed
the
fix_ci
branch
2 times, most recently
from
5e4c0c6
to
ffd5243
Compare
mkostoevr
approved these changes
Oct 16, 2024
CuriousGeorgiy
approved these changes
Oct 16, 2024
Containers with `ubuntu-22.04` had incompatible `gcc` and `libstdc++` versions, so we had to remove `gcc-13` and install `gcc-12`. However, the issue was fixed and `gcc-13` was removed, so our attempt to remove it by ourselves started to fail. The commit fixes this problem.
GitHub Actions does not support `macos-11` anymore - let's replace it with the newer versions.
Decoder can try to read zero bytes sometimes. For example, when it received an empty string. Let's simply handle this case in buffer instead of assertion. By the way, `ClientTest.cpp` was failing with Tarantool 3.2 because of this problem: when connector tries to call a non-existing function (`*** TEST CASE call wrong function ***`), Tarantool sends an empty string in response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patchset fixes
tntcxxCI.