Decoder: optimize decoding of optional and variant for scalar types #89
Conversation
CuriousGeorgiy
force-pushed
the
gh-85-optimize-optional-variant-decode
branch
2 times, most recently
from
24e3d5e
to
7420d5f
Compare
CuriousGeorgiy
force-pushed
the
gh-85-optimize-optional-variant-decode
branch
11 times, most recently
from
e67b648
to
e123c94
Compare
.clang-format
Outdated
| AlwaysBreakAfterReturnType: TopLevel | ||
| ContinuationIndentWidth: 8 | ||
| SpaceAfterTemplateKeyword: false |
There was a problem hiding this comment.
I'm not sure about this option.
In Dec.hpp and Traits.hpp, we have a space after template.
Also, as I noticed, project's author @alyapunov always puts this space.
There was a problem hiding this comment.
Dropped this change, didn't notice it, sorry.
CuriousGeorgiy
force-pushed
the
gh-85-optimize-optional-variant-decode
branch
2 times, most recently
from
8121598
to
9438157
Compare
CuriousGeorgiy
force-pushed
the
gh-85-optimize-optional-variant-decode
branch
from
9438157
to
f8849de
Compare
|
@drewdzzz Interestingly, what the linter reports looks like a clang frontend bug, as if it assumes that the |
| @@ -7,5 +7,6 @@ UseTab: Always | |||
|
|
|||
| AccessModifierOffset: -8 | |||
| AlwaysBreakAfterReturnType: TopLevel | |||
| ContinuationIndentWidth: 8 | |||
There was a problem hiding this comment.
It is already in master.
There was a problem hiding this comment.
Rebased on master.
src/mpp/Dec.hpp
Outdated
| @@ -1172,6 +1172,9 @@ bool jump_read_key(BUF& buf, T... t) | |||
| return jump_find_key<PAIRS, FAMILY, PATH>(val, IS, buf, t...); | |||
| } | |||
|
|
|||
| template <compact::Family FAMILY, size_t SUBRULE, class DST, class BUF> | |||
| constexpr bool is_object_readable_by_value_v = rule_by_family_t<FAMILY>::is_readable_by_value && std::is_assignable_v<DST, decltype(read_value<FAMILY, SUBRULE>(std::declval<BUF &>()))>; | |||
There was a problem hiding this comment.
Nit: it would be nice to move std::is_assignable_v to the next line - this one is too large.
There was a problem hiding this comment.
Added the ColumnLimit option (120) to our .clang-format.
The commit makes clang-format config more suitable to our codebase.
Currently, we always emplace an optional or variant in order to pass the value they contain forward, as a reference. This is required for complex nested types. However, if we are dealing with a scalar type, we can read its value into the optional or variant in-place. Closes tarantool#84
CuriousGeorgiy
force-pushed
the
gh-85-optimize-optional-variant-decode
branch
from
f8849de
to
3f65332
Compare
|
|
This patch optimizes the decoding of optional and variant values for scalar types.
Closes #84