Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: taosConn add atomic closed flag #265

Merged
merged 1 commit into from
May 20, 2024

Conversation

yinheli
Copy link
Contributor

@yinheli yinheli commented May 11, 2024

taosConn add atomic closed flag to prevent panic issues in concurrent scenarios issue: #228

@yinheli
Copy link
Contributor Author

yinheli commented May 13, 2024

Hi @huskar-t I wanted to gently follow up on this PR. Would you have some time to review it when you get a chance?

Also, I've been contemplating on the classification of this PR, would it be more fitting to categorize it as an enhancement or a bug fix? I'd appreciate your insights on this.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 79.15%. Comparing base (cff3f5e) to head (c7c8d2e).

Files Patch % Lines
taosWS/connection.go 40.00% 3 Missing and 3 partials ⚠️
taosWS/statement.go 0.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              3.0     #265      +/-   ##
==========================================
- Coverage   79.16%   79.15%   -0.01%     
==========================================
  Files          67       67              
  Lines        7204     7220      +16     
==========================================
+ Hits         5703     5715      +12     
- Misses        965      966       +1     
- Partials      536      539       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@huskar-t huskar-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huskar-t huskar-t requested a review from menshibin May 20, 2024 02:56
@huskar-t
Copy link
Collaborator

@menshibin please help review

@huskar-t huskar-t merged commit 2532a8e into taosdata:3.0 May 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants