feat: add support for paying with ERC20 or AssetId for services #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewstone
requested changes
Dec 5, 2024
|
Companion PR: tangle-network/tnt-core#43 |
drewstone
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
This pull request includes several updates and enhancements across multiple files, focusing on configuration changes, code refactoring, and new functionality. Here are the most important changes:
New Functionality:
pallets/services/src/functions.rs: Added new functionserc20_transferandquery_erc20_balance_ofto handle ERC20 token transfers and balance queries.Dependency and Import Updates:
pallets/services/Cargo.toml: Addedpallet-assetsto the workspace dependencies and included it in thestdfeature set. [1] [2]pallets/services/src/lib.rs: Introduced new traits for managing fungible assets and added new error types and event definitions for ERC20 transfers. [1] [2] [3]Enhancements and Bug Fixes:
pallets/services/src/lib.rs: Enhanced therequestfunction to support payment with different asset types, including native currency and ERC20 tokens. Added validation and transfer logic for these assets. [1] [2] [3]These changes collectively improve the codebase by enforcing consistent coding standards, refactoring for clarity, adding new functionalities, and enhancing existing features.
Reference issue to close (if applicable)
Part of tangle-network/tnt-core#28