Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : fix rpc result response and add tests #420

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix : fix rpc result response and add tests #420

merged 1 commit into from
Jan 10, 2024

Conversation

1xstj
Copy link
Contributor

@1xstj 1xstj commented Jan 10, 2024

Summary of changes
Changes introduced in this pull request:

  • Rpc query_phase_one_by_id is replaced with query_job_result
  • Add tests for all rpc endpoints

@1xstj 1xstj marked this pull request as ready for review January 10, 2024 18:22
@1xstj 1xstj requested a review from shekohex January 10, 2024 18:22
shekohex
shekohex approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@1xstj 1xstj merged commit c6751a3 into main Jan 10, 2024
6 checks passed
@1xstj 1xstj deleted the fix/report-phase branch January 10, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekohex shekohex shekohex approved these changes

@drewstone drewstone Awaiting requested review from drewstone drewstone is a code owner

@tbraun96 tbraun96 Awaiting requested review from tbraun96

@salman01zp salman01zp Awaiting requested review from salman01zp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1xstj @shekohex