Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #411

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Fix build #411

merged 2 commits into from
Jan 9, 2024

Conversation

salman01zp
Copy link
Contributor

@salman01zp salman01zp commented Jan 9, 2024 •
edited
Loading

Summary of changes
Changes introduced in this pull request:

  • Fix build
  • Update script to auto insert keys

Reference issue to close (if applicable)

Closes

@salman01zp salman01zp marked this pull request as ready for review January 9, 2024 06:31
@salman01zp salman01zp marked this pull request as draft January 9, 2024 06:32
@salman01zp salman01zp marked this pull request as ready for review January 9, 2024 06:38
@salman01zp salman01zp requested a review from AtelyPham January 9, 2024 06:38
AtelyPham
AtelyPham approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@AtelyPham AtelyPham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍!

@salman01zp salman01zp merged commit 9c6db76 into main Jan 9, 2024
6 checks passed
@salman01zp salman01zp deleted the salman/fix-release-build branch January 9, 2024 06:44
@salman01zp salman01zp self-assigned this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtelyPham AtelyPham AtelyPham approved these changes

@drewstone drewstone Awaiting requested review from drewstone drewstone is a code owner

@1xstj 1xstj Awaiting requested review from 1xstj 1xstj is a code owner

@tbraun96 tbraun96 Awaiting requested review from tbraun96

Assignees

@salman01zp salman01zp

Labels
None yet
Projects
Webb Universe
Status: Completed ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salman01zp @AtelyPham