Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Role key while creating profile #401

Merged
merged 9 commits into from
Jan 8, 2024
Merged

Conversation

salman01zp
Copy link
Contributor

@salman01zp salman01zp commented Jan 4, 2024

Summary of changes
Changes introduced in this pull request:

  • Store role key on profile
  • Update traits and impl to return role key
  • Update tests

Note

Removed metadata part for now since it is just role key. We will need to figure out a good way to take additional metadata user input for multiple different role types. cc: @1xstj

Reference issue to close (if applicable)

Closes #374

@salman01zp salman01zp marked this pull request as ready for review January 5, 2024 14:46
@salman01zp salman01zp merged commit a9aae11 into main Jan 8, 2024
6 checks passed
@salman01zp salman01zp deleted the salman/store-rolekey branch January 8, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Store Role key while creating profile.
2 participants