Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix claims pallet #394

Merged
merged 6 commits into from
Jan 4, 2024
Merged

bugfix: Fix claims pallet #394

merged 6 commits into from
Jan 4, 2024

Conversation

shekohex
Copy link
Contributor

@shekohex shekohex commented Jan 3, 2024

Summary of changes
Changes introduced in this pull request:

  • Update encoding for MultiAddress accounts (now we match over the type and only encode the inner value)
  • Fix polkadotjs message format, by adding the prefix and suffix.

Notes
I did provide two examples for claims in both Native accounts and EVM accounts

cc @AtelyPham Lmk if you will need help integrating the new format. but the tl;dr is that we now do not need the codecPrefix (i.e 0x30313031). Long version look into the diff.

Reference issue to close (if applicable)

Closes #393

Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deduplicate code pls @shekohex

pallets/claims/src/lib.rs Outdated Show resolved Hide resolved
@shekohex
Copy link
Contributor Author

shekohex commented Jan 3, 2024

Do not merge this one yet, until @AtelyPham confirms it works for him too on the dApp. I've tested it Locally with the mentioned scripts.

@AtelyPham AtelyPham self-requested a review January 3, 2024 17:51
pallets/claims/src/lib.rs Outdated Show resolved Hide resolved
@shekohex shekohex merged commit e795313 into main Jan 4, 2024
6 checks passed
@shekohex shekohex deleted the shady/fix-claims branch January 4, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Claims pallet
3 participants