-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared and Independent re-staking option for selected roles #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salman01zp
changed the title
Share re-stake for assigned roles
Shared and Independent re-staking option for selected roles
Dec 7, 2023
salman01zp
requested review from
drewstone,
1xstj and
tbraun96
as code owners
December 8, 2023 17:50
drewstone
reviewed
Dec 8, 2023
drewstone
reviewed
Dec 8, 2023
drewstone
reviewed
Dec 8, 2023
drewstone
reviewed
Dec 8, 2023
drewstone
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @salman01zp would suggest a few style changes/spelling/naming and otherwise looks good! I think we will need to properly review this 1:1 if you can book time and we can try to audit/break the mechanism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The validator can now create the profile by selecting roles he is interested in and with the option to stake independently for each role to be shared across all the roles.
New extrinsic:
Create Profile
Update Profile:
Delete Profile:
Remove Role:
Task Checklist
Reference issue to close (if applicable)
Closes #306
Closes #330