Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI to sign data using authority wdkg key #272

Merged
merged 3 commits into from
Oct 6, 2023
Merged

CLI to sign data using authority wdkg key #272

merged 3 commits into from
Oct 6, 2023

Conversation

1xstj
Copy link
Contributor

@1xstj 1xstj commented Oct 6, 2023 •
edited
Loading

Summary of changes
Changes introduced in this pull request:

  • CLI to sign data using authority wdkg key

Output :

./target/debug/tangle-standalone dkg-signer --data test
Signature : Some(4cced2b27ac145e0512abad5756fe45c173c130c18c80bdf0017ba0416edc690261bf1780b00dd30209dff8e13ce8df22d0402311d610cdd921bdff3a6a51b0101)

Reference issue to close (if applicable)

Closes tangle-network/dkg-substrate#717

@1xstj 1xstj marked this pull request as ready for review October 6, 2023 17:12
@1xstj 1xstj requested a review from shekohex October 6, 2023 17:12
drewstone
drewstone approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we version bump this so that we know which clients can't run this?

@drewstone drewstone merged commit 00126b9 into main Oct 6, 2023
7 of 10 checks passed
@drewstone drewstone deleted the sign-cli branch October 6, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone drewstone approved these changes

@tbraun96 tbraun96 Awaiting requested review from tbraun96

@shekohex shekohex Awaiting requested review from shekohex shekohex is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] CLI to sign data using authority wdkg key
2 participants
@1xstj @drewstone