Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schnorr MuSig Debugging + SDK improvements + SDK debugging #547

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tbraun96
Copy link
Collaborator

No description provided.

@tbraun96 tbraun96 added the DO NOT MERGE Please do not merge this PR yet, even if it is ready label Dec 13, 2024
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tjemmmic @tbraun96 please meet, since we're changing these contexts let's accelerate towards creating clients for them instead and making the contexts return these clients. It'll be a lot more easily to implement / debug rather than implementing inside a macro.

sdk/src/contexts/mpc.rs Outdated Show resolved Hide resolved
sdk/src/contexts/mpc.rs Outdated Show resolved Hide resolved
sdk/src/contexts/mpc.rs Outdated Show resolved Hide resolved
mux: std::sync::Arc<crate::network::NetworkMultiplexer>,
party_index: crate::round_based::PartyIndex,
task_hash: [u8; 32],
parties: std::collections::BTreeMap<crate::round_based::PartyIndex, crate::subxt_core::ext::sp_core::ecdsa::Public>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to generalize over sp_core::ecdsa::Public

@drewstone
Copy link
Contributor

What's the status of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Please do not merge this PR yet, even if it is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants