-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add a p2p test for testing the networking layer #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekohex
added
bug 🪲
Something isn't working
testing 🛠️
Tasks that are related to testing
DO NOT MERGE
Please do not merge this PR yet, even if it is ready
labels
Nov 6, 2024
fix: ensure stream key is properly set for MultiplexedSender
drewstone
reviewed
Nov 7, 2024
shekohex
commented
Nov 7, 2024
Serial-ATA
reviewed
Nov 7, 2024
tbraun96
force-pushed
the
shady/networking-issue
branch
from
November 7, 2024 19:35
d46d97d
to
75b7e23
Compare
tbraun96
removed
the
DO NOT MERGE
Please do not merge this PR yet, even if it is ready
label
Nov 8, 2024
drewstone
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes an addition of new test cases for the
network
module which adds comprehensive peer-to-peer (P2P) protocol tests.Testing Enhancements:
sdk/src/network/mod.rs
to test P2P protocol with multiple nodes, including setup functions and detailed round-based messaging tests.However, this test does not pass because of a bug in our networking layer, I've added this test mainly for @tbraun96 to be able to debug the networking layer better. This test simulate
N
nodes working together on a protocol. This protocol contains 3 rounds (Broadcast, P2P, Broadcast) which reflects our mostly used MPC protocols. Getting this fixed would allow for a lot of real-world applications like my blueprint here: https://github.com/tangle-network/frost-blueprint which currently is broken because of our networking implementation.Running the test
To run the test:
cargo test -p gadget-sdk network::tests::p2p -- --nocapture
You will get a similar log to mine: