Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk)!: allow for zero-based blueprint_id #426

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Conversation

shekohex
Copy link
Contributor

@shekohex shekohex commented Nov 1, 2024

This pull request includes several changes to the sdk module to improve the handling of service_id and streamline the configuration process for Tangle blueprints. The most important changes include making service_id optional, adjusting related methods, and removing redundant checks.

Changes to service_id handling:

Configuration adjustments:

  • sdk/src/config/mod.rs: Adjusted the load_inner function to handle service_id conditionally based on the registration mode.

Codebase simplification:

@shekohex shekohex force-pushed the shady/fix-tangle-runner branch from e94dbfc to 295d20b Compare November 1, 2024 12:58
@shekohex shekohex merged commit bdc4ec6 into main Nov 1, 2024
12 of 13 checks passed
@shekohex shekohex deleted the shady/fix-tangle-runner branch November 1, 2024 13:47
This was referenced Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants