fix(sdk)!: allow for zero-based blueprint_id
#426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
sdk
module to improve the handling ofservice_id
and streamline the configuration process for Tangle blueprints. The most important changes include makingservice_id
optional, adjusting related methods, and removing redundant checks.Changes to
service_id
handling:sdk/src/config/gadget_config.rs
: Modifiedservice_id
to be optional inGadgetConfiguration
and updated theservice_id
method to return the correct type. [1] [2]sdk/src/config/protocol.rs
: UpdatedTangleInstanceSettings
to makeservice_id
anOption<u64>
and added a note for registration mode.Configuration adjustments:
sdk/src/config/mod.rs
: Adjusted theload_inner
function to handleservice_id
conditionally based on the registration mode.Codebase simplification:
sdk/src/runners/tangle.rs
: Removed redundant checks forblueprint_id
inTangleConfig
to allow for zero-basedblueprint_id
s. [1] [2]