Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sqllite as an option to store signing keys #723

Merged
merged 8 commits into from
Dec 18, 2023

Conversation

1xstj
Copy link
Contributor

@1xstj 1xstj commented Oct 24, 2023

Summary of changes
Changes introduced in this pull request:

Reference issue to close (if applicable)
Closes #684 #716

@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (d5512ea) 18.79% compared to head (7bb9c2d) 18.77%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
- Coverage   18.79%   18.77%   -0.01%     
==========================================
  Files          80       80              
  Lines        5958     5963       +5     
==========================================
  Hits         1119     1119              
- Misses       4839     4844       +5     
Files Coverage Δ
dkg-primitives/src/types.rs 0.00% <0.00%> (ø)
dkg-gadget/src/lib.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drewstone drewstone marked this pull request as ready for review December 18, 2023 16:13
@drewstone drewstone merged commit 41d0447 into master Dec 18, 2023
2 of 7 checks passed
@drewstone drewstone deleted the sqllite-db-for-keys branch December 18, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK][Testnet] Investigate ways to backup signing keys of nodes
3 participants