Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Gossip Engine, Add Rust-based integration tests #706

Merged
merged 11 commits into from
Sep 12, 2023
Merged

Merge Gossip Engine, Add Rust-based integration tests #706

merged 11 commits into from
Sep 12, 2023

Conversation

tbraun96
Copy link
Contributor

@tbraun96 tbraun96 commented Sep 7, 2023 •
edited
Loading

Run the integration tests withcargo run --bin dkg-integration-tests

Resolves #693

@tbraun96 tbraun96 force-pushed the thomas/merge-gossip-engine branch from fd80622 to 3d224f8 Compare September 7, 2023 21:25
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.13% 🎉

Comparison is base (4ace8a6) 16.76% compared to head (c90e7d4) 16.89%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
+ Coverage   16.76%   16.89%   +0.13%     
==========================================
  Files          77       77              
  Lines        5734     5692      -42     
==========================================
  Hits          961      961              
+ Misses       4773     4731      -42
Files Changed Coverage Δ
dkg-gadget/src/dkg_modules/mp_ecdsa.rs 0.00% <ø> (ø)
...-gadget/src/gossip_messages/misbehaviour_report.rs 0.00% <0.00%> (ø)
dkg-gadget/src/lib.rs 0.00% <0.00%> (ø)
dkg-gadget/src/worker.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tbraun96 tbraun96 mentioned this pull request Sep 8, 2023
Closed
@drewstone
Copy link
Contributor

Is this still WIP?

@tbraun96 tbraun96 changed the title [WIP] Merge Gossip Engine, Add Rust-based integration tests Merge Gossip Engine, Add Rust-based integration tests Sep 11, 2023
drewstone
drewstone approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@drewstone drewstone merged commit da48f39 into master Sep 12, 2023
7 checks passed
@drewstone drewstone deleted the thomas/merge-gossip-engine branch September 12, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone drewstone approved these changes

@1xstj 1xstj Awaiting requested review from 1xstj 1xstj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge the split keygen/signing gossip engines
3 participants
@tbraun96 @codecov-commenter @drewstone