IOS-8666 [Balance caching] #4532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix review 1 Update `TotalBalanceProvider` Update TotalBalanceProvider.swift Update TotalBalanceProvider.swift Fix review 2 Update CommonExpressDestinationService.swift Revert "IOS-8907 [SQ] Add balance providers" This reverts commit 0d76749. IOS-8907 [SQ] Add balance providers IOS-8666 Regroup IOS-8907 Revert `walletDidChangePublisher ` IOS-8907 Update `BalanceProvider` IOS-8907 Update FormattedTokenBalanceType.swift IOS-8907 IOS-8666 Update `WalletModel+State` Fix review 3
Balashov152
requested review from
skibinalexander,
m3g0byt3,
Andoran90,
fedorov-d and
ViacheslavEfimenko
Balashov152
commented
Jan 23, 2025
Comment on lines
+214
to
+220
| lazy var availableBalanceProvider = makeAvailableBalanceProvider() | ||
| lazy var stakingBalanceProvider = makeStakingBalanceProvider() | ||
| lazy var totalTokenBalanceProvider = makeTotalTokenBalanceProvider() | ||
|
|
||
| lazy var fiatAvailableBalanceProvider = makeFiatAvailableBalanceProvider() | ||
| lazy var fiatStakingBalanceProvider = makeFiatStakingBalanceProvider() | ||
| lazy var fiatTotalTokenBalanceProvider = makeFiatTotalTokenBalanceProvider() |
There was a problem hiding this comment.
Перенес сюда что бы сделать lazy и что бы не нужно было анприватить tokenRepository
ViacheslavEfimenko
approved these changes
Jan 24, 2025
fedorov-d
approved these changes
Jan 27, 2025
skibinalexander
approved these changes
Jan 27, 2025
Andoran90
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4 / 4
Код остался тот же что и на демо, еще раз все протестил, все ок
но все равно гляньте плиз свои части в приле с балансами. Что бы MR не казался таким большим для вас )
@fedorov-d - по staking
@m3g0byt3 - по organize tokens
@Andoran90 - по visa
@skibinalexander - по wallet selector
@ViacheslavEfimenko - по action buttons