AND-7983 [Staking] Implemented enter staking Polkadot #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iMaks99
commented
Nov 29, 2024
•
iMaks99
commented
- AND-9119 [Staking] Implemented staking Polkadot. BSDK part blockchain-sdk-kotlin#848
Pull reviewers statsStats of the last 30 days for tangem-app-android:
|
Sateetas
reviewed
Dec 2, 2024
| @@ -88,6 +89,10 @@ internal object NetworkModule { | |||
| context = context, | |||
| apiConfigsManager = apiConfigsManager, | |||
| clientBuilder = { | |||
| this.callTimeout(STAKE_KIT_API_TIMEOUT_SECONDS, TimeUnit.SECONDS) | |||
There was a problem hiding this comment.
мб заюзаем наш класс Timeouts?
плюс эти 4 строки где-то в соседнем апи тоже используются, можно
вынести проставление таймаутов + обработку аннотаций в отдельный метод/экстеншн-метод с параметром timeoutSeconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.