Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AND-8870 Setup R8 obfuscation #3774

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nzeeei
Copy link
Contributor

@nzeeei nzeeei commented Nov 20, 2024

No description provided.

@nzeeei nzeeei requested a review from a team as a code owner November 20, 2024 11:04
Copy link

Pull reviewers stats

Stats of the last 30 days for tangem-app-android:

User Total reviews Time to review Total comments
kozarezvlad 77 1h 36m 19
iMaks99 59 2h 13m 8
nzeeei 55 1h 26m 7
Yoggam1 45 1h 29m 7
Mama1emon 40 2h 51m 40
MasterBin 40 1h 4m 14
Sateetas 31 1h 2m 17
iiiburnyiii 17 26m 1
nemelianov-tangem 2 14m 0
ekuzovkin 2 3h 6m 0
thebrodyaga 1 3m 0

⚡️ Pull request stats

@nzeeei nzeeei force-pushed the feature/AND-8870-setup-obfuscation branch 2 times, most recently from b50f45e to 68dbc2b Compare November 20, 2024 11:08
Comment on lines -22 to +24
msgs: List<Message>,
) : WcBinanceOrder<WcBinanceCancelOrder.Message>(accountNumber, chainId, data, memo, sequence, source, msgs) {
val msgs: List<Message>,
) : WcRequestData {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Есть такая ижья: square/moshi#1729, к сожалению, PR висит открытым с прошлого года. Поэтому убрал тут наследование, оно ничего и не давало

@nzeeei nzeeei force-pushed the feature/AND-8870-setup-obfuscation branch from 68dbc2b to 76d283f Compare November 25, 2024 04:58
MasterBin
MasterBin previously approved these changes Nov 25, 2024
iMaks99
iMaks99 previously approved these changes Nov 25, 2024
@nzeeei nzeeei dismissed stale reviews from iMaks99 and MasterBin via 6c0410d November 25, 2024 09:13
@nzeeei nzeeei force-pushed the feature/AND-8870-setup-obfuscation branch from 76d283f to 6c0410d Compare November 25, 2024 09:13
@nzeeei nzeeei force-pushed the feature/AND-8870-setup-obfuscation branch 2 times, most recently from 65cec70 to 6839159 Compare December 4, 2024 09:28
@nzeeei nzeeei force-pushed the feature/AND-8870-setup-obfuscation branch from 6839159 to 3b07b83 Compare December 5, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants