-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AND-8870 Setup R8 obfuscation #3774
Open
nzeeei
wants to merge
1
commit into
develop
Choose a base branch
from
feature/AND-8870-setup-obfuscation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for tangem-app-android:
|
nzeeei
force-pushed
the
feature/AND-8870-setup-obfuscation
branch
2 times, most recently
from
November 20, 2024 11:08
b50f45e
to
68dbc2b
Compare
nzeeei
commented
Nov 20, 2024
Comment on lines
-22
to
+24
msgs: List<Message>, | ||
) : WcBinanceOrder<WcBinanceCancelOrder.Message>(accountNumber, chainId, data, memo, sequence, source, msgs) { | ||
val msgs: List<Message>, | ||
) : WcRequestData { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Есть такая ижья: square/moshi#1729, к сожалению, PR висит открытым с прошлого года. Поэтому убрал тут наследование, оно ничего и не давало
nzeeei
commented
Nov 20, 2024
...com/tangem/feature/wallet/presentation/wallet/ui/components/visa/VisaTxDetailsBottomSheet.kt
Show resolved
Hide resolved
Sateetas
reviewed
Nov 20, 2024
app/src/main/java/com/tangem/tap/network/exchangeServices/mercuryo/MercuryoApi.kt
Outdated
Show resolved
Hide resolved
nzeeei
force-pushed
the
feature/AND-8870-setup-obfuscation
branch
from
November 25, 2024 04:58
68dbc2b
to
76d283f
Compare
MasterBin
previously approved these changes
Nov 25, 2024
iMaks99
previously approved these changes
Nov 25, 2024
nzeeei
force-pushed
the
feature/AND-8870-setup-obfuscation
branch
from
November 25, 2024 09:13
76d283f
to
6c0410d
Compare
nzeeei
force-pushed
the
feature/AND-8870-setup-obfuscation
branch
2 times, most recently
from
December 4, 2024 09:28
65cec70
to
6839159
Compare
nzeeei
force-pushed
the
feature/AND-8870-setup-obfuscation
branch
from
December 5, 2024 06:36
6839159
to
3b07b83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.