AND-8610, AND-8611, AND-8612, AND-8613 Casper integration #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterBin
reviewed
Oct 16, 2024
...src/main/java/com/tangem/blockchain/blockchains/casper/network/response/CasperRpcResponse.kt
Show resolved
Hide resolved
Mama1emon
reviewed
Oct 18, 2024
blockchain/src/main/java/com/tangem/blockchain/blockchains/casper/CasperProvidersBuilder.kt
Show resolved
Hide resolved
blockchain/src/main/java/com/tangem/blockchain/blockchains/casper/CasperWalletManager.kt
Outdated
Show resolved
Hide resolved
blockchain/src/main/java/com/tangem/blockchain/blockchains/casper/CasperWalletManager.kt
Show resolved
Hide resolved
blockchain/src/main/java/com/tangem/blockchain/blockchains/casper/models/CasperBalance.kt
Outdated
Show resolved
Hide resolved
...hain/src/main/java/com/tangem/blockchain/blockchains/casper/network/CasperNetworkProvider.kt
Outdated
Show resolved
Hide resolved
...va/com/tangem/blockchain/blockchains/casper/network/converters/CasperBalanceBodyConverter.kt
Outdated
Show resolved
Hide resolved
...n/java/com/tangem/blockchain/blockchains/casper/network/provider/CasperRpcNetworkProvider.kt
Outdated
Show resolved
Hide resolved
Yoggam1
reviewed
Oct 18, 2024
blockchain/src/main/java/com/tangem/blockchain/blockchains/casper/CasperWalletManager.kt
Outdated
Show resolved
Hide resolved
Comment on lines
30
to
32
| if (balance.balance != wallet.amounts[AmountType.Coin]?.value) { | ||
| wallet.recentTransactions.clear() | ||
| } |
There was a problem hiding this comment.
Нету явного механизма проверки статуса транзакции?
There was a problem hiding this comment.
Пока так, возможно в финальном реквесту изменится логика
dbaturin
approved these changes
Oct 21, 2024
kozarezvlad
approved these changes
Oct 22, 2024
Mama1emon
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Разбито по коммитам