-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AND-8609: Add CasperAddressService #804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mama1emon
reviewed
Oct 11, 2024
blockchain/src/main/java/com/tangem/blockchain/blockchains/casper/CasperAddressService.kt
Outdated
Show resolved
Hide resolved
blockchain/src/main/java/com/tangem/blockchain/blockchains/casper/CasperConstants.kt
Outdated
Show resolved
Hide resolved
nzeeei
force-pushed
the
feature/AND-8609-casper-address-service
branch
from
October 11, 2024 08:03
89188cb
to
e98a864
Compare
Mama1emon
previously approved these changes
Oct 11, 2024
ndbaturin
suggested changes
Oct 11, 2024
blockchain/src/main/java/com/tangem/blockchain/blockchains/casper/CasperAddressService.kt
Outdated
Show resolved
Hide resolved
blockchain/src/main/java/com/tangem/blockchain/blockchains/casper/cashaddr/CasperCashAddr.kt
Outdated
Show resolved
Hide resolved
blockchain/src/main/java/com/tangem/blockchain/extensions/ByteArray.kt
Outdated
Show resolved
Hide resolved
nzeeei
force-pushed
the
feature/AND-8609-casper-address-service
branch
2 times, most recently
from
October 11, 2024 16:02
7b582e9
to
9d245c6
Compare
nzeeei
force-pushed
the
feature/AND-8609-casper-address-service
branch
from
October 11, 2024 16:04
9d245c6
to
e735529
Compare
ndbaturin
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ещё бы тест кейс для sameCase адресов добавить не помешало
Yoggam1
approved these changes
Oct 14, 2024
dbaturin
approved these changes
Oct 14, 2024
Mama1emon
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.