AND-5742 [BlockchainSdk] Add checking utxo amount limit #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMaks99
requested review from
roman-pv,
iiiburnyiii,
Mama1emon,
kozarezvlad,
Yoggam1 and
Sateetas
as code owners
iiiburnyiii
reviewed
Dec 29, 2023
| @@ -29,9 +29,13 @@ class KaspaTransactionBuilder { | |||
|
|
|||
| val unspentsToSpend = getUnspentsToSpend() | |||
|
|
|||
| val change: BigDecimal = calculateChange(transactionData, unspentsToSpend) | |||
| val change = calculateChange( | |||
| amount = transactionData.amount.value!!, | |||
There was a problem hiding this comment.
Предлагаю через requireNotNull с текстом ошбки сделать
iMaks99
force-pushed
the
feature/AND-5742_BlockchainSdk_Add_checking_utxo_amount_limit
branch
from
5ad5859 to
fa7d65d
Compare
Mama1emon
previously approved these changes
Dec 29, 2023
iMaks99
force-pushed
the
feature/AND-5742_BlockchainSdk_Add_checking_utxo_amount_limit
branch
from
fa7d65d to
6101215
Compare
Mama1emon
approved these changes
Dec 29, 2023
iiiburnyiii
approved these changes
Dec 29, 2023
iMaks99
deleted the
feature/AND-5742_BlockchainSdk_Add_checking_utxo_amount_limit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.