AND-4852 Added ExternalLinkProvider's #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoggam1
requested review from
roman-pv,
iiiburnyiii,
Mama1emon,
kozarezvlad and
Sateetas
as code owners
Sateetas
reviewed
Oct 25, 2023
| internal class NearExternalLinkProvider(isTestnet: Boolean) : ExternalLinkProvider { | ||
|
|
||
| override val explorerBaseUrl: String = | ||
| if (isTestnet) "https://explorer.testnet.near.org/" else "https://explorer.near.org/" |
There was a problem hiding this comment.
поправишь base explore url и explore tx url? я недавно менял в релизной ветке
иначе потом затрется или разъедется, и получим больной мерж
Yoggam1
force-pushed
the
feature/AND-4852_external_link_provider
branch
from
fc36980 to
20d74b6
Compare
Sateetas
approved these changes
Oct 27, 2023
iMaks99
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.