Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sc-42350 per item discount bugfix #20

Merged
merged 5 commits into from
Sep 30, 2024
Merged

fix: sc-42350 per item discount bugfix #20

merged 5 commits into from
Sep 30, 2024

Conversation

sebastiancarlsson
Copy link
Contributor

  • fixes bug where only the first item in a cart would be discounted if a per item discount should be applied to several (or all) items.
  • adds unit test with mocks to check the above.

fixes 42350

altJake
altJake previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@altJake altJake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing this 🙏
Looking good to me, just one comment I left should probably addressed before merging, about the comment in the extension file - other than that, I think we are ready to merge it 👍

src/api-extension/models/cart-action-factory.js Show resolved Hide resolved
src/api-extension/models/cart-action-factory.js Outdated Show resolved Hide resolved
src/api-extension/mocks/talonone/update-customer-session-with-per-item-discount-response.json Show resolved Hide resolved
altJake
altJake approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@altJake altJake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go from my end 🚀

@sebastiancarlsson sebastiancarlsson merged commit 34723c9 into master Sep 30, 2024
1 check passed
@sebastiancarlsson sebastiancarlsson deleted the sc-42350-commercetools-accelerator-only-discounting branch September 30, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altJake altJake altJake approved these changes

@cBrenDev cBrenDev Awaiting requested review from cBrenDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastiancarlsson @altJake