Skip to content

Commit

Permalink
Update expected SNR values
Browse files Browse the repository at this point in the history
  • Loading branch information
talister committed Feb 22, 2024
1 parent f76aed7 commit bab6365
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions tests/etc/test_etc.py
Original file line number Diff line number Diff line change
Expand Up @@ -480,12 +480,10 @@ def setUp(self):
}

def test_LCO_1m_1s_V15_default_sky(self):
expected_snr = 10.4210644
expected_snr = 11.9973

test_etc = etc.ETC(self.test_config_file)
print(f"test_etc = {test_etc}")
snr = test_etc.ccd_snr(1, 15, "V")
print("snr, type=", snr, type(snr))
assert_quantity_allclose(expected_snr, snr, rtol=1e-5)

def test_LCO_1m_1s_bad_filter(self):
Expand All @@ -498,7 +496,7 @@ def test_LCO_1m_1s_bad_filter(self):
assert execinfo.value.args[0] == "Filter name Vibble is invalid."

def test_LCO_1m_1s_V15(self):
expected_snr = 10.4210644
expected_snr = 11.9973

test_etc = etc.ETC(self.test_config_file)

Expand All @@ -507,7 +505,7 @@ def test_LCO_1m_1s_V15(self):
assert_quantity_allclose(expected_snr, snr, rtol=1e-5)

def test_LCO_1m_1s_R15(self):
expected_snr = 10.815680017464334
expected_snr = 14.85152

test_etc = etc.ETC(self.test_config_file)

Expand Down Expand Up @@ -544,8 +542,8 @@ def test_WHT_1s_B15(self):

def test_WHT_5s_R15(self):
# Also a mismatch for R although not as severe. Default is 3080 Jy;
# Value below from a recompile using 3857.0 Jy
expected_snr = 476.35858154
# Value below from a recompile using 3057.0 Jy
expected_snr = 478.6

extin = 0.09 # mag/airmass (from SIGNAL)
airmass = 1.2
Expand Down

0 comments on commit bab6365

Please sign in to comment.