Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #17

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Develop #17

wants to merge 4 commits into from

Conversation

thrykol
Copy link

@thrykol thrykol commented Dec 29, 2012

Added support for a node js compiler on Linux systems. Compiler used is determined by a factory which will check the OS and the existence of the 'sh', 'cat', and 'coffee' commands. If all requirements are met, the node.js compiler will be used, otherwise it defaults back to the Rhino compiler.

On my machine, the build time was reduced by about 63% when using the node path.

@buildhive
Copy link

Mark Derricutt » coffee-maven-plugin #18 SUCCESS
This pull request looks good
(what's this?)

@talios
Copy link
Owner

talios commented Jan 3, 2013

Hi there - started to take a look at this - good stuff! I've been meaning to implement something like this for awhile to speed up our own builds.

One thing thou, I'm not sure I like the fact its tied specifically to linux, so I'm likely to merge this to a feature branch and introduce support for the maven-toolchains-plugin which I'd been meaning to integrate for awhile.

This gives an OS neutral way to locate node be it on Linux, OSX etc. and also makes it specifically clear that you want the project to build with node, or in our case - a customized spidermonkey build ).

@talios
Copy link
Owner

talios commented Jan 3, 2013

I also have a local branch which removes Rhino in favor of dyn.js which is getting closer to being merged, so this refactoring will help with this as well for a transition period.

@thrykol
Copy link
Author

thrykol commented Jan 3, 2013

Glad you like it. I work in a Linux environment and wanted to make sure things continued to work for all other environments. Thus the factory which defaults back to Rhino if the requirements aren't met. I agree that it should be more OS independent. The more versatile it can be made, the better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants