fix(build): Persists credentials

.chglog/CHANGELOG.tpl.md

@@ -1,11 +1,12 @@
+{{ $repositoryURL := .Info.RepositoryURL }}
 {{ if .Versions -}}
 {{ if .Unreleased.CommitGroups }}
 <a name="unreleased"></a>
-## [Unreleased]({{ .Info.RepositoryURL }}/compare/{{ $latest := index .Versions 0 }}{{ $latest.Tag.Name }}...HEAD)
+## [Unreleased]({{ $repositoryURL }}/compare/{{ $latest := index .Versions 0 }}{{ $latest.Tag.Name }}...HEAD)
 {{ range .Unreleased.CommitGroups -}}
 ### {{ .Title }}
 {{ range .Commits -}}
-- {{ if .Scope }}**{{ .Scope }}:** {{ end }}{{ .Subject }}
+- {{ if .Scope }}**{{ .Scope }}:** {{ end }}[{{ .Hash.Short }}]({{ $repositoryURL }}/commit/{{ .Hash.Long }}) {{ .Subject }}
 {{ end }}
 {{ end -}}
 {{ range .Unreleased.NoteGroups -}}
@@ -17,11 +18,11 @@
 {{ end -}}
 {{ range .Versions }}
 <a name="{{ .Tag.Name }}"></a>
-## {{ if .Tag.Previous }}[{{ .Tag.Name }}]({{ $.Info.RepositoryURL }}/compare/{{ .Tag.Previous.Name }}...{{ .Tag.Name }}){{ else }}{{ .Tag.Name }}{{ end }} ({{ datetime "2006-01-02" .Tag.Date }})
+## {{ if .Tag.Previous }}[{{ .Tag.Name }}]({{ $repositoryURL }}/compare/{{ .Tag.Previous.Name }}...{{ .Tag.Name }}){{ else }}{{ .Tag.Name }}{{ end }} ({{ datetime "2006-01-02" .Tag.Date }})
 {{ range .CommitGroups -}}
 ### {{ .Title }}
 {{ range .Commits -}}
-- {{ if .Scope }}**{{ .Scope }}:** {{ end }}{{ .Subject }}
+- {{ if .Scope }}**{{ .Scope }}:** {{ end }}[{{ .Hash.Short }}]({{ $repositoryURL }}/commit/{{ .Hash.Long }}) {{ .Subject }}
 {{ end }}
 {{ end -}}
 {{ range .NoteGroups -}}

.github/workflows/create-release.yml

@@ -11,11 +11,14 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v4
         with:
           # Fetches entire history, so we can analyze commits since last tag
           fetch-depth: 0
-          persist-credentials: false
+          persist-credentials: true
+          fetch-tags: true
+          repository: ${{ github.event.pull_request.head.repo.full_name }}
+          ref: ${{ github.event.pull_request.head.ref }}
       - uses: Bpazy/setup-git-chglog@v1
         with:
           git-chglog-version: ${{ env.GIT_CHGLOG_VERSION}}
@@ -31,9 +34,9 @@ jobs:
           prerelease_version="$(svu prerelease --tag-mode all-branches --strip-prefix --pre-release prerelease)"
           release_version="$(svu next --tag-mode all-branches --strip-prefix)"
 
-          echo ::set-output name=CURRENT_VERSION::${current_version}
-          echo ::set-output name=PRERELEASE_VERSION::${prerelease_version}
-          echo ::set-output name=RELEASE_VERSION::${release_version}
+          echo "CURRENT_VERSION=${current_version}" >> $GITHUB_OUTPUT
+          echo "PRERELEASE_VERSION=${prerelease_version}" >> $GITHUB_OUTPUT
+          echo "RELEASE_VERSION=${release_version}" >> $GITHUB_OUTPUT
 
           echo "current version: ${current_version}"
           echo "prerelease version: ${prerelease_version}"
@@ -47,3 +50,5 @@ jobs:
           default_author: github_actions
           message: "chore(release): v${{ steps.get_version.outputs.RELEASE_VERSION }}"
           add: "CHANGELOG.md"
+          tag: "v${{ steps.get_version.outputs.RELEASE_VERSION }}"
+          tag_push: '--force'

.github/workflows/release.yml

@@ -255,6 +255,10 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
+          persist-credentials: true
+          fetch-tags: true
+          repository: ${{ github.event.pull_request.head.repo.full_name }}
+          ref: ${{ github.event.pull_request.head.ref }}
       - uses: Bpazy/setup-git-chglog@v1
         with:
           git-chglog-version: ${{ env.GIT_CHGLOG_VERSION}}
@@ -269,10 +273,10 @@ jobs:
           current_version="$(svu current --tag-mode current-branch --strip-prefix)"
           prerelease_version="$(svu prerelease --tag-mode all-branches --strip-prefix --pre-release prerelease)"
           release_version="$(svu next --tag-mode all-branches --strip-prefix)"
-          
-          echo ::set-output name=CURRENT_VERSION::${current_version}
-          echo ::set-output name=PRERELEASE_VERSION::${prerelease_version}
-          echo ::set-output name=RELEASE_VERSION::${release_version}
+
+          echo "CURRENT_VERSION=${current_version}" >> $GITHUB_OUTPUT
+          echo "PRERELEASE_VERSION=${prerelease_version}" >> $GITHUB_OUTPUT
+          echo "RELEASE_VERSION=${release_version}" >> $GITHUB_OUTPUT
 
           echo "current version: ${current_version}"
           echo "prerelease version: ${prerelease_version}"
@@ -298,6 +302,7 @@ jobs:
         with:
           gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }}
           #passphrase: ${{ secrets.PASSPHRASE }}  
+
       - name: goreleaser release
         uses: goreleaser/goreleaser-action@v5
         if: startsWith(github.ref, 'refs/tags/v')
@@ -309,6 +314,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           GORELEASER_CURRENT_TAG: ${{ steps.get_version.outputs.RELEASE_VERSION }}
           GORELEASER_PREVIOUS_TAG: ${{ steps.get_version.outputs.CURRENT_VERSION }}
+
       - name: generate change log for prerelease
         if: "!(startsWith(github.ref, 'refs/tags/v'))"
         run: |
@@ -334,18 +340,20 @@ jobs:
           *)
             ARTIFACT="${GITHUB_REF}";;
           esac
-          echo "::set-output name=ARTIFACT::$ARTIFACT-$(date -u +'%Y-%m-%dT%H-%M')"
+
+          ARTIFACT="${ARTIFACT}-$(date -u +'%Y-%m-%dT%H-%M')"
+          echo "ARTIFACT=${ARTIFACT}" >> $GITHUB_OUTPUT
       - name: upload snapshot artifact
         uses: actions/upload-artifact@v4
         if: "!(startsWith(github.ref, 'refs/tags/v'))"
         with:
           name: ${{steps.naming.outputs.ARTIFACT}}
           path: dist/*.zip
+
       - name: Add updated changelog, and create new branch
         uses: EndBug/add-and-commit@v9
         if: "!(startsWith(github.ref, 'refs/tags/v'))"
         with:
           default_author: github_actions
           message: "chore(release): v${{ steps.get_version.outputs.PRERELEASE_VERSION }}"
           add: "CHANGELOG.md"
-          new_branch: "v${{ steps.get_version.outputs.PRERELEASE_VERSION }}"

CHANGELOG.md

@@ -1,67 +1,80 @@
 
+
 <a name="v1.1.0-prerelease.0"></a>
-## [v1.1.0-prerelease.0](https://github.com/taliesins/terraform-provider-hyperv/compare/v1.0.4...v1.1.0-prerelease.0) (2023-12-26)
+## [v1.1.0-prerelease.0](https://github.com/taliesins/terraform-provider-hyperv/compare/v1.0.4...v1.1.0-prerelease.0) (2023-12-27)
 ### Build
-- add semantic release
+- [7ab008e](https://github.com/taliesins/terraform-provider-hyperv/commit/7ab008e24cac705707c648e11002378d34ad3f29) add semantic release
 
 ### Chore
-- **deps:** bump golang.org/x/net from 0.7.0 to 0.17.0
-- **deps:** bump amannn/action-semantic-pull-request
-- **deps:** bump actions/setup-go from 3 to 4
-- **deps:** bump actions/cache from 3.2.1 to 3.3.1
-- **deps:** bump golang.org/x/net from 0.4.0 to 0.7.0
-- **deps:** bump goreleaser/goreleaser-action from 4.1.0 to 4.2.0
-- **deps:** bump actions/cache from 3.0.11 to 3.2.1
+- **deps:** [65ba5b7](https://github.com/taliesins/terraform-provider-hyperv/commit/65ba5b79f21a1cb10c6b313a0c3d23d05a4d86e7) bump amannn/action-semantic-pull-request
+- **deps:** [68d0fc2](https://github.com/taliesins/terraform-provider-hyperv/commit/68d0fc25ffb168f661110731fb58ee204189197d) bump actions/cache from 3.0.11 to 3.2.1
+- **deps:** [e5a1ab9](https://github.com/taliesins/terraform-provider-hyperv/commit/e5a1ab9256f1782a9fa9f1e03bfcd43ed7d00aec) bump hashicorp/setup-terraform from 2.0.3 to 3.0.0
+- **deps:** [bb74d73](https://github.com/taliesins/terraform-provider-hyperv/commit/bb74d7361894c7341338b280aa77c1c8a3399620) bump crazy-max/ghaction-import-gpg from 6.0.0 to 6.1.0
+- **deps:** [48a9870](https://github.com/taliesins/terraform-provider-hyperv/commit/48a98702d460eda03d83fa91e2792bcbe8207984) bump actions/cache from 3.3.1 to 3.3.2
+- **deps:** [2aad898](https://github.com/taliesins/terraform-provider-hyperv/commit/2aad898d8f1b3b173808913afe08c42a5c1d8c7d) bump actions/setup-go from 4 to 5
+- **deps:** [46860cc](https://github.com/taliesins/terraform-provider-hyperv/commit/46860cc721e49e4b83634e91c3c90978bbd470da) bump actions/checkout from 3 to 4
+- **deps:** [777fdf6](https://github.com/taliesins/terraform-provider-hyperv/commit/777fdf60ec9c84d382aa02e4c345cfd1f2d8cc6a) bump golang.org/x/crypto from 0.14.0 to 0.17.0
+- **deps:** [2c4d21d](https://github.com/taliesins/terraform-provider-hyperv/commit/2c4d21ddef33fbb8cb269231507f5d8fa75ccf96) bump actions/upload-artifact from 3 to 4
+- **deps:** [59e00c2](https://github.com/taliesins/terraform-provider-hyperv/commit/59e00c28bb8bea65ec6b9ba82687308984272992) bump goreleaser/goreleaser-action from 4.1.0 to 4.2.0
+- **deps:** [7ef6010](https://github.com/taliesins/terraform-provider-hyperv/commit/7ef6010f7cdcfdd9bb93c464fcfacf34716f2e19) bump google.golang.org/grpc from 1.51.0 to 1.56.3
+- **deps:** [e0d2b06](https://github.com/taliesins/terraform-provider-hyperv/commit/e0d2b065ebf59d7f314ec4ba6dcb72422b974a14) bump crazy-max/ghaction-import-gpg from 5.2.0 to 6.0.0
+- **deps:** [e8045f2](https://github.com/taliesins/terraform-provider-hyperv/commit/e8045f2914f902dfddd8cbb0abc7d3f052d9dc1d) bump golang.org/x/net from 0.7.0 to 0.17.0
+- **deps:** [22694a3](https://github.com/taliesins/terraform-provider-hyperv/commit/22694a3e439f80f72b2aa29a524aa74d3fd8c23c) bump amannn/action-semantic-pull-request
+- **deps:** [395f0a4](https://github.com/taliesins/terraform-provider-hyperv/commit/395f0a432aca0cdf75d898b8058cb390c6e340b7) bump actions/setup-go from 3 to 4
+- **deps:** [72e5111](https://github.com/taliesins/terraform-provider-hyperv/commit/72e51115e6f837449cd6422b41433b616dec8935) bump actions/cache from 3.2.1 to 3.3.1
+- **deps:** [b353437](https://github.com/taliesins/terraform-provider-hyperv/commit/b3534370fbb78cac28627b01fe0f4a8b0a20f016) bump golang.org/x/net from 0.4.0 to 0.7.0
+- **release:** [3a111cc](https://github.com/taliesins/terraform-provider-hyperv/commit/3a111cc01465d9078bf7f01c8ca46ba1d13a1c3c) v1.1.0-prerelease.0
+- **release:** [bf2a962](https://github.com/taliesins/terraform-provider-hyperv/commit/bf2a962722a7e652df2e24f30914de5f9ebae642) v1.1.0-prerelease.0
 
 ### Feat
-- fix build
+- [5c1fd8b](https://github.com/taliesins/terraform-provider-hyperv/commit/5c1fd8bc40b7124718322fc1f6cbc8ee686a1462) fix build
 
 
 <a name="v1.0.4"></a>
 ## [v1.0.4](https://github.com/taliesins/terraform-provider-hyperv/compare/v1.0.3...v1.0.4) (2022-12-14)
 ### Chore
-- **deps:** bump actions/cache from 3.0.8 to 3.0.10
-- **deps:** bump github.com/hashicorp/terraform-plugin-sdk/v2
-- **deps:** bump github.com/hashicorp/terraform-plugin-sdk/v2
-- **deps:** bump hashicorp/setup-terraform from 2.0.2 to 2.0.3
-- **deps:** bump crazy-max/ghaction-import-gpg from 5.1.0 to 5.2.0
-- **deps:** bump goreleaser/goreleaser-action from 3.1.0 to 3.2.0
-- **deps:** bump amannn/action-semantic-pull-request
-- **deps:** bump actions/cache from 3.0.10 to 3.0.11
-- **deps:** bump actions/cache from 3.0.2 to 3.0.8
-- **deps:** bump amannn/action-semantic-pull-request
-- **deps:** bump actions/upload-artifact from 2 to 3
-- **deps:** bump goreleaser/goreleaser-action from 3.2.0 to 4.1.0
-- **deps:** bump hashicorp/setup-terraform from 2.0.0 to 2.0.2
-- **deps:** bump goreleaser/goreleaser-action from 3.0.0 to 3.1.0
-- **deps:** bump github.com/hashicorp/terraform-plugin-docs
-- **deps:** bump crazy-max/ghaction-import-gpg from 4.3.0 to 5.1.0
-- **deps:** bump goreleaser/goreleaser-action from 2.9.1 to 3.0.0
-- **deps:** bump amannn/action-semantic-pull-request
-- **deps:** bump amannn/action-semantic-pull-request
-- **deps:** bump github.com/jolestar/go-commons-pool/v2
-- **deps:** bump hashicorp/setup-terraform from 1.4.0 to 2.0.0
-- **release:** v1.0.4
+- **deps:** [51d8f4b](https://github.com/taliesins/terraform-provider-hyperv/commit/51d8f4b2b809c38ec3adab7c34291c959ad70483) bump actions/cache from 3.0.8 to 3.0.10
+- **deps:** [63e2616](https://github.com/taliesins/terraform-provider-hyperv/commit/63e2616c0d29d925ec3a255c0d1eea7bc5791798) bump github.com/hashicorp/terraform-plugin-sdk/v2
+- **deps:** [3372e5a](https://github.com/taliesins/terraform-provider-hyperv/commit/3372e5af4c5283162bca53a567a36afd50c3ae7f) bump github.com/hashicorp/terraform-plugin-sdk/v2
+- **deps:** [1e445f0](https://github.com/taliesins/terraform-provider-hyperv/commit/1e445f0228f44000d4c224e720ccf477707c9023) bump hashicorp/setup-terraform from 2.0.2 to 2.0.3
+- **deps:** [9dc9339](https://github.com/taliesins/terraform-provider-hyperv/commit/9dc9339b4b9263cb59abab9f124430df0a1250d1) bump crazy-max/ghaction-import-gpg from 5.1.0 to 5.2.0
+- **deps:** [4d6ac61](https://github.com/taliesins/terraform-provider-hyperv/commit/4d6ac612ab4e5d1aa3038a3cf4af8f4256861cd4) bump goreleaser/goreleaser-action from 3.1.0 to 3.2.0
+- **deps:** [85421c4](https://github.com/taliesins/terraform-provider-hyperv/commit/85421c43e84096755b9c06ff03f8bc9a550edfbd) bump amannn/action-semantic-pull-request
+- **deps:** [e860385](https://github.com/taliesins/terraform-provider-hyperv/commit/e860385d266c3f18001e7e938f4ead363b69eec9) bump actions/cache from 3.0.10 to 3.0.11
+- **deps:** [a6982c3](https://github.com/taliesins/terraform-provider-hyperv/commit/a6982c31c0c8c17d42c036208492a5011edb97bd) bump actions/cache from 3.0.2 to 3.0.8
+- **deps:** [9f29a71](https://github.com/taliesins/terraform-provider-hyperv/commit/9f29a7153a06d2f101a129aa8124b508c826954d) bump amannn/action-semantic-pull-request
+- **deps:** [6e0f104](https://github.com/taliesins/terraform-provider-hyperv/commit/6e0f104451bcb02498667c8622398718461af078) bump actions/upload-artifact from 2 to 3
+- **deps:** [dc03fb8](https://github.com/taliesins/terraform-provider-hyperv/commit/dc03fb8bd16ad2284cc5db77c5a7461eb17955da) bump goreleaser/goreleaser-action from 3.2.0 to 4.1.0
+- **deps:** [5075896](https://github.com/taliesins/terraform-provider-hyperv/commit/507589668fc6a2359104dcc49a33dfd62b1cdcb7) bump hashicorp/setup-terraform from 2.0.0 to 2.0.2
+- **deps:** [0422b3f](https://github.com/taliesins/terraform-provider-hyperv/commit/0422b3fac65e271667b9ed81de639268ecf5a66b) bump goreleaser/goreleaser-action from 3.0.0 to 3.1.0
+- **deps:** [30f7554](https://github.com/taliesins/terraform-provider-hyperv/commit/30f7554aacb7d02cf4e2e31e9f42ded5ecb2fd9f) bump github.com/hashicorp/terraform-plugin-docs
+- **deps:** [50e34f2](https://github.com/taliesins/terraform-provider-hyperv/commit/50e34f25ddb55a480a099d840a58140d405d7340) bump crazy-max/ghaction-import-gpg from 4.3.0 to 5.1.0
+- **deps:** [e9cbaf8](https://github.com/taliesins/terraform-provider-hyperv/commit/e9cbaf84b63ffb039885c5576bb14ba88319aec5) bump goreleaser/goreleaser-action from 2.9.1 to 3.0.0
+- **deps:** [a4e2008](https://github.com/taliesins/terraform-provider-hyperv/commit/a4e2008de1e53018992d1ea9bd19f52e30ace7e7) bump amannn/action-semantic-pull-request
+- **deps:** [6e086ac](https://github.com/taliesins/terraform-provider-hyperv/commit/6e086ac03b73f16ac9ed879b282c7c5b43780203) bump amannn/action-semantic-pull-request
+- **deps:** [90eb2b1](https://github.com/taliesins/terraform-provider-hyperv/commit/90eb2b1834fc01e0595ca22f8b9442907b92dee2) bump github.com/jolestar/go-commons-pool/v2
+- **deps:** [176ca62](https://github.com/taliesins/terraform-provider-hyperv/commit/176ca62bba8b2d62438621887c0b8e2963fe5e0e) bump hashicorp/setup-terraform from 1.4.0 to 2.0.0
+- **release:** [6214acf](https://github.com/taliesins/terraform-provider-hyperv/commit/6214acfdee0302cbd1b3560554078d7a62a53e70) v1.0.4
 
 
 <a name="v1.0.3"></a>
 ## [v1.0.3](https://github.com/taliesins/terraform-provider-hyperv/compare/v1.0.2...v1.0.3) (2021-03-20)
 ### Chore
-- **release:** v1.0.3
+- **release:** [514c264](https://github.com/taliesins/terraform-provider-hyperv/commit/514c264c07877996d90d02ee328899e5f28672b0) v1.0.3
 
 ### Fix
-- improve error message to make it obvious what to do when this error occurs
-- **static-or-dynamic:** use schema to ensure exclusive selection of dynamic or static memory
-- **static-or-dynamic:** don't default to static, but rather force people to chose static over dynamic.
+- [da23bf6](https://github.com/taliesins/terraform-provider-hyperv/commit/da23bf6c7acde50fbe3bc14b2a7d5a4f0b96f3e1) improve error message to make it obvious what to do when this error occurs
+- **static-or-dynamic:** [89a245e](https://github.com/taliesins/terraform-provider-hyperv/commit/89a245e71e427f846fe8144b55afc277896c31a5) use schema to ensure exclusive selection of dynamic or static memory
+- **static-or-dynamic:** [da10a53](https://github.com/taliesins/terraform-provider-hyperv/commit/da10a536792f8f3cecba6c988c011eff65866812) don't default to static, but rather force people to chose static over dynamic.
 
 
 <a name="v1.0.2"></a>
 ## [v1.0.2](https://github.com/taliesins/terraform-provider-hyperv/compare/v1.0.1...v1.0.2) (2021-03-09)
 ### Chore
-- **release:** v1.0.2
+- **release:** [86e36bf](https://github.com/taliesins/terraform-provider-hyperv/commit/86e36bfbd28c8e3d432f4047e1ceee613b37c27d) v1.0.2
 
 ### Ci
-- do not persist credentials
+- [db19a46](https://github.com/taliesins/terraform-provider-hyperv/commit/db19a46de238f8bdf5ce83a6694ebaf6a8e91585) do not persist credentials
 
 
 <a name="v1.0.1"></a>
@@ -70,5 +83,5 @@
 <a name="v1.0.0"></a>
 ## v1.0.0 (2020-09-23)
 ### Bugfix
-- IsValid() -> !IsValid()
+- [d06fc13](https://github.com/taliesins/terraform-provider-hyperv/commit/d06fc1314f26f81989dfcdda1ff5782e627ea5e6) IsValid() -> !IsValid()