added wandb logger and extended when to log #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takuseno
requested changes
Feb 17, 2024
There was a problem hiding this comment.
@claudius-kienle Thank you for your contribution! This is awesome! I have some minor comments that I'd like you to address before we merge this. Please take a look. Thanks again!
|
@takuseno Thank you for the review. All your comments should now be included. |
takuseno
requested changes
Feb 17, 2024
d3rlpy/constants.py
Outdated
| @@ -47,3 +47,8 @@ class ActionSpace(Enum): | |||
| class PositionEncodingType(Enum): | |||
| SIMPLE = "simple" | |||
| GLOBAL = "global" | |||
|
|
|||
|
|
|||
| class LoggingStrategyEnum(Enum): | |||
There was a problem hiding this comment.
Could you rename this to LoggingStrategy?
There was a problem hiding this comment.
Of course. I just changed it.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
==========================================
- Coverage 91.96% 91.61% -0.36%
==========================================
Files 113 114 +1
Lines 8012 8047 +35
==========================================
+ Hits 7368 7372 +4
- Misses 644 675 +31 ☔ View full report in Codecov by Sentry. |
takuseno
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a wandb logger adapter and also added to new parameters to customize when to log.
This will close #362