Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DroQ #342

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add DroQ #342

wants to merge 2 commits into from

Conversation

asmith26
Copy link
Contributor

Attempt at #340 (WIP)

@asmith26 asmith26 marked this pull request as draft September 30, 2023 11:01
@asmith26 asmith26 changed the title Add Droq Add DroQ Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #342 (3099def) into master (43e6769) will decrease coverage by 0.20%.
The diff coverage is 73.97%.

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
- Coverage   92.69%   92.49%   -0.20%     
==========================================
  Files         109      111       +2     
  Lines        7141     7208      +67     
==========================================
+ Hits         6619     6667      +48     
- Misses        522      541      +19     
Files Coverage Δ
d3rlpy/algos/qlearning/__init__.py 100.00% <100.00%> (ø)
d3rlpy/algos/qlearning/base.py 88.21% <100.00%> (+0.03%) ⬆️
d3rlpy/models/encoders.py 97.10% <100.00%> (+0.08%) ⬆️
d3rlpy/models/torch/encoders.py 93.58% <50.00%> (-0.57%) ⬇️
d3rlpy/algos/qlearning/torch/droq_impl.py 58.33% <58.33%> (ø)
d3rlpy/algos/qlearning/droq.py 73.46% <73.46%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@takuseno
Copy link
Owner

takuseno commented Oct 1, 2023

@asmith26 Thank you for the PR! The overall approach looks good to me. Let me know when this PR is ready for review.

@takuseno takuseno self-requested a review October 1, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants