Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala to 2.13.12 #278

Merged
merged 9 commits into from
Nov 13, 2023
Merged

Update Scala to 2.13.12 #278

merged 9 commits into from
Nov 13, 2023

Conversation

lefou
Copy link
Contributor

@lefou lefou commented Nov 3, 2023

This PR updates from Scala 2.12 to 2.13. With the update to Scala 2.13.12, which is the latest available Scala 2.x version, polyglot-scala should also support Java 21.

I suggest to have this PR and PR #277 (which updates from Scala 2.11 to 2.12) not in the same release, to give users of polyglot-scala a chance to migrate their builds step by step. But TBH, I have no clue how many users we still have.

Along this update, I bumped various dependencies, migrated some Scala syntax and fixed deprecated or removed API call sites. I also fixed some issues with left-open file resources.

@lefou lefou marked this pull request as draft November 3, 2023 14:10
@lefou lefou changed the title update scala 2.13 Update Scala to 2.13.12 Nov 3, 2023
@cstamas
Copy link
Member

cstamas commented Nov 4, 2023

@lefou sorry, but I merged the other PR and now there are quite some conflicts 😞

@lefou lefou marked this pull request as ready for review November 4, 2023 20:48
@lefou
Copy link
Contributor Author

lefou commented Nov 7, 2023

@cstamas I rebased this PR. It's ready for review and merge, although, I'd prefer if you could cut a 0.6.0 release before the merge, and a 0.7.0 release after it, due to the major change in Scala version and its potential implications for users. Thanks!

@cstamas
Copy link
Member

cstamas commented Nov 7, 2023

So just to clarify:

  • release current master as 0.6.0
  • merge this PR, release 0.7.0

Pls confirm

@lefou
Copy link
Contributor Author

lefou commented Nov 7, 2023

So just to clarify:

* release current master as 0.6.0

* merge this PR, release 0.7.0

Pls confirm

Exactly that. 👍‍

@cstamas cstamas merged commit f7245ea into takari:master Nov 13, 2023
4 checks passed
@lefou
Copy link
Contributor Author

lefou commented Nov 13, 2023

Thank you!

@lefou lefou deleted the update-scala-2.13 branch November 13, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants