Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Upgrade webpack to version 4 #26

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jsparedes
Copy link

To upgrade the webpack starter (#13). Webpack v4 works with mini-css-extract-plugin instead of extract-text-webpack-plugin

image

@SuperSarkar
Copy link

Any updates on this?

@adamwathan
Copy link
Member

I think the master branch is already updated for webpack 4 if I'm not mistaken?

https://github.com/tailwindcss/webpack-starter/blob/master/package.json

@jsparedes
Copy link
Author

I think the master branch is already updated for webpack 4 if I'm not mistaken?

https://github.com/tailwindcss/webpack-starter/blob/master/package.json

You are right, it is updated with webpack v4 but using extract-text-webpack-plugin

And according to webpack:

Since webpack v4 the extract-text-webpack-plugin should not be used for css. Use mini-css-extract-plugin instead

Maybe the pull request title should be: webpack v4 starter with mini-css-extract-plugin

Finally, thanks for your amazing work in tailwindcss. I will try the v1.0.0-beta.3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants