Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: bump targetSdkVersion to 35, update dependencies #597

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agottardo
Copy link
Collaborator

No description provided.

@agottardo agottardo requested review from barnstar and kari-ts January 15, 2025 17:33
@kari-ts
Copy link
Collaborator

kari-ts commented Jan 15, 2025

Have you done testing to ensure we're supporting Android 15 behavior changes?

@agottardo
Copy link
Collaborator Author

Have you done testing to ensure we're supporting Android 15 behavior changes?

Yes, things seemed to work well. I still need to test Taildrop though.

@kari-ts
Copy link
Collaborator

kari-ts commented Jan 15, 2025

Have you done testing to ensure we're supporting Android 15 behavior changes?

Yes, things seemed to work well. I still need to test Taildrop though.

Awesome! Thanks for doing this!

@kari-ts kari-ts closed this Jan 15, 2025
@kari-ts kari-ts reopened this Jan 15, 2025
Copy link
Member

@barnstar barnstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to bump the build container version in the makefile so the builder regenerates the docker image with the new toolchains.

To keep the build reasonably fast, we don't regenerate the entire image on every build.

DOCKER_IMAGE=tailscale-android-build-amd64-191124

to

DOCKER_IMAGE=tailscale-android-build-amd64-160125

The last 6 digits are just the date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants