android: lazily init app in Client #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnstar
reviewed
Nov 19, 2024
| initOnce() // Calls the synchronized initialization logic | ||
| } | ||
| } | ||
|
|
||
| @Synchronized | ||
| private fun initOnce() { | ||
| if (isInitialized) { | ||
| return | ||
| } | ||
| isInitialized = true |
There was a problem hiding this comment.
The method is synchronized so it's OK, but let's defer setting isInitialized to the end of the method since, technically, nothing isInitialzied at this point.
Does kotlin have a built in "run this block of code once and only once" construct? In Swift, we would do dispatch_once() here (or use a closure) instead of a volatile bool and the synchronization.
There was a problem hiding this comment.
it doesn't afaik. I think the best we can do is the combination of the volatile isInitialized and the synchronization.
-Lazily init app in Client to ensure that we aren't trying to make any local API calls before app has been initialized. -Add @volatile to ensure that isInitialized is always visible across threads and uses the updated value Updates tailscale/tailscale#14125 Signed-off-by: kari-ts <[email protected]>
barnstar
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Lazily init app in Client to ensure that we aren't trying to make any local API calls before app has been initialized.
-Add @volatile to ensure that isInitialized is always visible across threads and uses the updated value
Updates tailscale/tailscale#14125