android: use native search #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kari-ts
force-pushed
the
kari/newsearch
branch
2 times, most recently
from
1db019f to
e7972af
Compare
kari-ts
force-pushed
the
kari/newsearch
branch
3 times, most recently
from
ee0cce5 to
bc417f3
Compare
|
Looking now ... |
|
On an API level 30 emulated device, the layout jumps a bit when I select the Search bar. search_recording.webm |
|
Other than the above layout issue, it's working well for me. |
barnstar
requested changes
Oct 28, 2024
kari-ts
force-pushed
the
kari/newsearch
branch
from
bc417f3 to
900fbbf
Compare
|
I used AnimatedVisibility to make the expansion animation a bit smoother. This keeps the initial search bar in place while expanding the content below it. |
oxtoacart
approved these changes
Oct 28, 2024
agottardo
approved these changes
Oct 29, 2024
barnstar
reviewed
Oct 29, 2024
-Add dynamic suggestions -Use search bar with expanded view showing suggestions -dpad: only open keyboard when clicked on and not on scroll Updates tailscale/corp#18973 Fixes tailscale/corp#19231 Signed-off-by: kari-ts <[email protected]>
kari-ts
force-pushed
the
kari/newsearch
branch
from
900fbbf to
a1ffcaf
Compare
|
fixed! PTAL |
barnstar
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add dynamic suggestions
-Use search bar with expanded view showing suggestions
Updates tailscale/corp#18973