Makefile: use "tailscale_go" build tag when using Tailscale's Go toolchain #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chain Updates tailscale/tailscale#13527 Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz
force-pushed
the
bradfitz/tailscale_go
branch
from
98eb426 to
4b4cef3
Compare
raggi
approved these changes
Sep 20, 2024
agottardo
reviewed
Sep 20, 2024
| echo "tailscale_go" | ||
| else | ||
| # Otherwise, if TOOLCHAIN_DIR is specified, we assume | ||
| # we're F-Droid or something using a stock Go toolchain. |
There was a problem hiding this comment.
Does this mean we're allowing F-Droid to put out Tailscale APKs that will crash on older Android versions due to not using our toolchain?
There was a problem hiding this comment.
We won't assert the toolchain version is correct without the tailscale_go build tag. So f-droid is unaffected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tailscale/tailscale#13527