android: fix vpn #232
Merged
android: fix vpn #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Move most of prepare and establish VPN logic out of Go into Android -Fix prepareVPN argument to use request codes to differentiate sign in and prepare VPN -Fix missing adapter implementation (setMtu) Updates tailscale/corp#18202 Signed-off-by: kari-ts <[email protected]>
agottardo
approved these changes
Mar 22, 2024
oxtoacart
reviewed
Mar 22, 2024
| @@ -120,32 +120,10 @@ type InputStream interface { | |||
| // The below are global callbacks that allow the Java application to notify Go | |||
| // of various state changes. | |||
|
|
|||
| func OnVPNPrepared() { | |||
oxtoacart
reviewed
Mar 22, 2024
| func RequestVPN(service IPNService) { | ||
| onVPNRequested <- service | ||
| } | ||
|
|
||
| func ServiceDisconnect(service IPNService) { | ||
| onDisconnect <- service | ||
| } | ||
|
|
||
| func OnActivityResult(reqCode, resCode int, idToken string) { |
oxtoacart
reviewed
Mar 22, 2024
| // TODO: send null Google token | ||
| break; | ||
| } | ||
| // TODO: send Google token |
There was a problem hiding this comment.
Are we keeping Google Signin, or are we switching just to browser-based sign in because of fast user switching?
There was a problem hiding this comment.
Browser based, but I do want to investigate what we were using the google token for and make sure that we don't break anything by removing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Move most of prepare and establish VPN logic out of Go into Android
-Fix prepareVPN argument to use request codes to differentiate sign in and prepare VPN
-Fix missing adapter implementation (setMtu)
Updates tailscale/corp#18202