android: implement fast user switching #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agottardo
approved these changes
Mar 16, 2024
| @@ -13,9 +13,12 @@ val ts_color_light_tintedBackground = Color(0xFFF7F5F4) | |||
| val ts_color_light_blue = Color(0xFF4B70CC) | |||
| val ts_color_light_green = Color(0xFF1EA672) | |||
|
|
|||
| var ts_color_dark_desctrutive_text = Color(0xFFFF0000) | |||
There was a problem hiding this comment.
Suggested change
| var ts_color_dark_desctrutive_text = Color(0xFFFF0000) | |
| var ts_color_dark_destructive_text = Color(0xFFFF0000) |
| @@ -13,9 +13,12 @@ val ts_color_light_tintedBackground = Color(0xFFF7F5F4) | |||
| val ts_color_light_blue = Color(0xFF4B70CC) | |||
| val ts_color_light_green = Color(0xFF1EA672) | |||
|
|
|||
| var ts_color_dark_desctrutive_text = Color(0xFFFF0000) | |||
| var ts_color_light_desctrutive_text = Color(0xFFBB0000) | |||
There was a problem hiding this comment.
Suggested change
| var ts_color_light_desctrutive_text = Color(0xFFBB0000) | |
| var ts_color_light_destructive_text = Color(0xFFBB0000) |
| ) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Composable | ||
| fun ClearButton(onClick: () -> Unit) { |
There was a problem hiding this comment.
Move these to a Buttons.kt file?
barnstar
force-pushed
the
jonathan/fast_user_switching
branch
3 times, most recently
from
ccfe701 to
3edf3fd
Compare
agottardo
approved these changes
Mar 18, 2024
Updates tailscale/corp#18202 Updates ENG-2875 Fixes ENG-2863 Adds everything we need to do fast user switching and support multiple accounts. Some work here to make the settings rows and a few other composables common and reusable. Correct the focus and clear behavior on the search bar and corrected the connected in state of SelfNode. Quick fix for requesting VPN permissions on newer Android phones. Signed-off-by: Jonathan Nobels <[email protected]>
barnstar
force-pushed
the
jonathan/fast_user_switching
branch
from
3edf3fd to
0853bff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tailscale/corp#18202
Updates ENG-2875
Fixes ENG-2863
Adds everything we need to do fast user switching and support multiple accounts.
Some work here to make the settings rows and a few other composables common and reusable.
Added quick but incomplete support for requesting VPN permissions in the new activity.
Correct the focus and clear behaviour on the search bar and corrected the connected in state of SelfNode.