Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl reqactor #448

Merged
merged 9 commits into from
Jan 22, 2025
Merged

feat: impl reqactor #448

merged 9 commits into from
Jan 22, 2025

Conversation

keroro520
Copy link
Contributor

No description provided.

@keroro520 keroro520 requested a review from smtmfft January 13, 2025 06:44
Copy link
Contributor

@smtmfft smtmfft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
1 thing to clarify that you actually limit the concurreny by that 1024 channel? in burst there will be a problem cause networking I/O stuck, as potentially there are 1024 tasks asking for huge data transfer. That's why we used to have a self-impled software pending list, you can take this into consideration when you do next step.

reqactor/src/backend.rs Outdated Show resolved Hide resolved
reqactor/src/backend.rs Show resolved Hide resolved
@keroro520
Copy link
Contributor Author

LGTM! 1 thing to clarify that you actually limit the concurreny by that 1024 channel? in burst there will be a problem cause networking I/O stuck, as potentially there are 1024 tasks asking for huge data transfer. That's why we used to have a self-impled software pending list, you can take this into consideration when you do next step.

I think the concurrency is already limited by max_proving_concurrency via Semaphore:

https://github.com/taikoxyz/raiko/pull/448/files#diff-dcbc7e4a44885478ec09bb1109302f660ccb5aa04faa1871544fa5e91b74a118R334-R342

@keroro520 keroro520 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into taikoxyz:main with commit 26470be Jan 22, 2025
6 checks passed
@keroro520 keroro520 deleted the feat/reqactor branch January 22, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants