-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl reqactor #448
feat: impl reqactor #448
Conversation
7fb4052
to
13d45cf
Compare
13d45cf
to
17883a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
1 thing to clarify that you actually limit the concurreny by that 1024 channel? in burst there will be a problem cause networking I/O stuck, as potentially there are 1024 tasks asking for huge data transfer. That's why we used to have a self-impled software pending list, you can take this into consideration when you do next step.
I think the concurrency is already limited by |
No description provided.