Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9721 - Remove tui-form classes from demo #9990

Merged

Conversation

shiv9604
Copy link
Contributor

Partially Fixes #9721

Description :

  1. Create example 2 in styles > foundations > form for migrating tui-form classes to form layout component.
  2. Add a deprecation warning.
  3. Shift the form component to layouts > form.
  4. Migrate remaining tui-form classes to form layout component

@shiv9604 shiv9604 self-assigned this Dec 15, 2024
@shiv9604 shiv9604 requested a review from a team as a code owner December 15, 2024 08:55
@shiv9604 shiv9604 requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 15, 2024 08:55
Copy link

lumberjack-bot bot commented Dec 15, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@shiv9604 shiv9604 changed the title #9721 - Migrate tui-form classes from demo #9721 - Migrate tui-form classes from demo Dec 15, 2024
@shiv9604 shiv9604 changed the title #9721 - Migrate tui-form classes from demo #9721 - Remove migrate tui-form classes from demo Dec 15, 2024
Copy link

bundlemon bot commented Dec 15, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/runtime.(hash).js
44.05KB (-15B -0.03%) +10%
demo/browser/main.(hash).js
304.48KB (-84B -0.03%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.25KB +10%
demo/browser/styles.(hash).css
20.2KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change -99B -0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.36MB (-31.22KB -0.41%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode force-pushed the feature/9721-migrate-tui-form-classes branch from cadf957 to d4817a4 Compare December 15, 2024 17:39
@shiv9604 shiv9604 changed the title #9721 - Remove migrate tui-form classes from demo #9721 - Remove tui-form classes from demo Dec 16, 2024
@shiv9604 shiv9604 force-pushed the feature/9721-migrate-tui-form-classes branch from d4817a4 to f86cb7c Compare December 18, 2024 10:28
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (08f924d) to head (bcb3658).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #9990       +/-   ##
==========================================
- Coverage   65.77%       0   -65.78%     
==========================================
  Files        1219       0     -1219     
  Lines       15811       0    -15811     
  Branches     2272       0     -2272     
==========================================
- Hits        10400       0    -10400     
+ Misses       5188       0     -5188     
+ Partials      223       0      -223     
Flag Coverage Δ
summary ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiv9604
Copy link
Contributor Author

Hi @waterplea & @splincode, I just wanted to keep you posted that we have resolved the PR comments for this PR.

@waterplea waterplea merged commit 296bc4b into taiga-family:main Dec 20, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - Demo should not use any of "tui-" classes other than spacings
3 participants