Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): InputPhoneInternational refactor to new textfield approach #9976

Merged
merged 20 commits into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {MaskitoDirective} from '@maskito/angular';
import {TUI_MASK_CARD} from '@taiga-ui/addon-commerce/constants';
import {TUI_PAYMENT_SYSTEM_ICONS} from '@taiga-ui/addon-commerce/tokens';
import {tuiControlValue} from '@taiga-ui/cdk/observables';
import {TuiTextfieldContent} from '@taiga-ui/core/components/textfield';
import {TuiTextfieldContent, TuiWithTextfield} from '@taiga-ui/core/components/textfield';
import {tuiInjectIconResolver} from '@taiga-ui/core/tokens';
import {tuiMaskito} from '@taiga-ui/kit/utils';
import {distinctUntilChanged, map, skip, startWith, switchMap, timer} from 'rxjs';
Expand All @@ -38,7 +38,7 @@ import {TUI_INPUT_CARD_OPTIONS} from './input-card.options';
styleUrls: ['./input-card.style.less'],
encapsulation: ViewEncapsulation.None,
changeDetection: ChangeDetectionStrategy.OnPush,
hostDirectives: [MaskitoDirective],
hostDirectives: [MaskitoDirective, TuiWithTextfield],
host: {
inputmode: 'numeric',
placeholder: '0000 0000 0000 0000',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@ import {Directive, inject, Input} from '@angular/core';
import {MaskitoDirective} from '@maskito/angular';
import {TUI_INPUT_CARD_OPTIONS} from '@taiga-ui/addon-commerce/components/input-card';
import {TUI_MASK_CVC} from '@taiga-ui/addon-commerce/constants';
import {TuiWithTextfield} from '@taiga-ui/core/components/textfield';
import {tuiMaskito} from '@taiga-ui/kit/utils';

@Directive({
standalone: true,
selector: 'input[tuiInputCVC]',
hostDirectives: [MaskitoDirective],
hostDirectives: [MaskitoDirective, TuiWithTextfield],
host: {
inputmode: 'numeric',
'[autocomplete]': 'autocomplete ? "cc-csc" : "off"',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@ import {Directive, inject, Input} from '@angular/core';
import {MaskitoDirective} from '@maskito/angular';
import {TUI_INPUT_CARD_OPTIONS} from '@taiga-ui/addon-commerce/components/input-card';
import {TUI_MASK_EXPIRE} from '@taiga-ui/addon-commerce/constants';
import {TuiWithTextfield} from '@taiga-ui/core/components/textfield';
import {tuiMaskito} from '@taiga-ui/kit/utils';

@Directive({
standalone: true,
selector: 'input[tuiInputExpire]',
hostDirectives: [MaskitoDirective],
hostDirectives: [MaskitoDirective, TuiWithTextfield],
host: {
inputmode: 'numeric',
placeholder: '00/00',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ export class TuiDropdownMobile {
if (
!this.isMobile ||
!tuiIsHTMLElement(event.target) ||
!event.target.matches('input,textarea')
!event.target.matches('input,textarea') ||
this.tuiDropdownMobile
) {
return;
}
Expand Down
17 changes: 15 additions & 2 deletions projects/core/components/textfield/textfield.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class TuiTextfieldBase<T> implements OnChanges {
protected readonly s = tuiAppearanceState(null);
protected readonly m = tuiAppearanceMode(this.mode);
protected readonly f = tuiAppearanceFocus(
computed(() => this.focused() || this.textfield.focused()),
computed(() => this.focused() ?? this.textfield.focused()),
);

protected readonly el = tuiInjectElement<HTMLInputElement>();
Expand Down Expand Up @@ -99,7 +99,9 @@ export class TuiTextfieldBase<T> implements OnChanges {

@Directive({
standalone: true,
selector: 'input[tuiTextfield]',
// TODO: Remove :not in v.5
selector:
'input[tuiTextfield]:not([tuiInputCard]):not([tuiInputExpire]):not([tuiInputCVC])',
hostDirectives: [TuiNativeValidator, TuiAppearance],
host: {
'[id]': 'textfield.id',
Expand All @@ -111,3 +113,14 @@ export class TuiTextfieldBase<T> implements OnChanges {
},
})
export class TuiTextfieldDirective<T> extends TuiTextfieldBase<T> {}

@Directive({
standalone: true,
hostDirectives: [
{
directive: TuiTextfieldDirective,
inputs: ['invalid', 'focused', 'readOnly', 'state'],
},
],
})
export class TuiWithTextfield {}
18 changes: 7 additions & 11 deletions projects/core/directives/dropdown/dropdown-open.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,19 +137,15 @@ export class TuiDropdownOpen implements OnChanges {

protected onKeydown({key, target, defaultPrevented}: KeyboardEvent): void {
if (
defaultPrevented ||
!tuiIsEditingKey(key) ||
!this.editable ||
!this.focused ||
!this.directive.content ||
!tuiIsHTMLElement(target) ||
(tuiIsElementEditable(target) && target !== this.host)
!defaultPrevented &&
tuiIsEditingKey(key) &&
this.editable &&
this.focused &&
tuiIsHTMLElement(target) &&
!tuiIsElementEditable(target)
) {
return;
this.host.focus({preventScroll: true});
}

this.update(true);
this.host.focus({preventScroll: true});
}

private get host(): HTMLElement {
Expand Down
1 change: 1 addition & 0 deletions projects/core/styles/components/textfield.less
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,7 @@ tui-textfield {
gap: 0.25rem;
margin-inline-start: auto;
isolation: isolate;
border-radius: inherit;

> tui-icon {
pointer-events: auto;
Expand Down
23 changes: 22 additions & 1 deletion projects/core/styles/theme/appearance/textfield.less
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,28 @@
outline-offset: -1px;
border: none;

// TODO: Remove tuiWrapper hack in v5
&:not([tuiWrapper])::before,
&:not([tuiWrapper])::after {
.transition(~'color, transform');

color: var(--tui-text-tertiary);
}

.appearance-hover({
--t-shadow: 0 0.125rem 0.3125rem rgba(0, 0, 0, 0.16);

&:not([tuiWrapper]):before,
&:not([tuiWrapper]):after {
color: var(--tui-text-secondary);
}
});

.appearance-active({
&:not([tuiWrapper]):before,
&:not([tuiWrapper]):after {
color: var(--tui-text-primary);
}
});

.appearance-focus({
Expand All @@ -33,7 +53,8 @@

&[data-mode~='readonly'],
input&:read-only:not([data-mode]) {
box-shadow: none;
background: transparent !important;
box-shadow: none !important;
outline-color: var(--tui-border-normal) !important;
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,18 +1,24 @@
import {DemoRoute} from '@demo/routes';
import {TuiDocumentationPagePO, tuiGoto} from '@demo-playwright/utils';
import {
TuiDocumentationPagePO,
tuiGoto,
TuiInputPhoneInternationalPO,
} from '@demo-playwright/utils';
import type {Locator} from '@playwright/test';
import {expect, test} from '@playwright/test';

test.describe('InputPhoneInternational', () => {
test.describe('API page', () => {
let example: Locator;
let select!: Locator;
let dropdown!: Locator;
let inputPhoneInternational!: TuiInputPhoneInternationalPO;

test.beforeEach(({page}) => {
example = new TuiDocumentationPagePO(page).apiPageExample;
select = example.locator('tui-input-phone-international select');
dropdown = page.locator('tui-dropdown');
inputPhoneInternational = new TuiInputPhoneInternationalPO(
example.locator('tui-textfield'),
);
});

test('Open dropdown if readonly=false', async ({page}) => {
Expand All @@ -23,7 +29,7 @@

await expect(dropdown).not.toBeAttached();

await select.click();
await inputPhoneInternational.select.click();

Check failure on line 32 in projects/demo-playwright/tests/legacy/input-phone-international/input-phone-international.pw.spec.ts

View workflow job for this annotation

GitHub Actions / Playwright / ubuntu-latest / 8 of 9

[chromium] › tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:24:13 › InputPhoneInternational › API page › Open dropdown if readonly=false

1) [chromium] › tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:24:13 › InputPhoneInternational › API page › Open dropdown if readonly=false TimeoutError: locator.click: Timeout 10000ms exceeded. Call log: - waiting for locator('#demo-content').locator('tui-textfield').locator('.t-ipi-select') 30 | await expect(dropdown).not.toBeAttached(); 31 | > 32 | await inputPhoneInternational.select.click(); | ^ 33 | 34 | await expect(dropdown).toBeAttached(); 35 | }); at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:32:50

Check failure on line 32 in projects/demo-playwright/tests/legacy/input-phone-international/input-phone-international.pw.spec.ts

View workflow job for this annotation

GitHub Actions / Playwright / ubuntu-latest / 8 of 9

[chromium] › tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:24:13 › InputPhoneInternational › API page › Open dropdown if readonly=false

1) [chromium] › tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:24:13 › InputPhoneInternational › API page › Open dropdown if readonly=false Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── TimeoutError: locator.click: Timeout 10000ms exceeded. Call log: - waiting for locator('#demo-content').locator('tui-textfield').locator('.t-ipi-select') 30 | await expect(dropdown).not.toBeAttached(); 31 | > 32 | await inputPhoneInternational.select.click(); | ^ 33 | 34 | await expect(dropdown).toBeAttached(); 35 | }); at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:32:50

Check failure on line 32 in projects/demo-playwright/tests/legacy/input-phone-international/input-phone-international.pw.spec.ts

View workflow job for this annotation

GitHub Actions / Playwright / ubuntu-latest / 8 of 9

[chromium] › tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:24:13 › InputPhoneInternational › API page › Open dropdown if readonly=false

1) [chromium] › tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:24:13 › InputPhoneInternational › API page › Open dropdown if readonly=false Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── TimeoutError: locator.click: Timeout 10000ms exceeded. Call log: - waiting for locator('#demo-content').locator('tui-textfield').locator('.t-ipi-select') 30 | await expect(dropdown).not.toBeAttached(); 31 | > 32 | await inputPhoneInternational.select.click(); | ^ 33 | 34 | await expect(dropdown).toBeAttached(); 35 | }); at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:32:50

Check failure on line 32 in projects/demo-playwright/tests/legacy/input-phone-international/input-phone-international.pw.spec.ts

View workflow job for this annotation

GitHub Actions / Playwright / macos-latest / 8 of 9

[webkit] › tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:24:13 › InputPhoneInternational › API page › Open dropdown if readonly=false

1) [webkit] › tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:24:13 › InputPhoneInternational › API page › Open dropdown if readonly=false TimeoutError: locator.click: Timeout 10000ms exceeded. Call log: - waiting for locator('#demo-content').locator('tui-textfield').locator('.t-ipi-select') 30 | await expect(dropdown).not.toBeAttached(); 31 | > 32 | await inputPhoneInternational.select.click(); | ^ 33 | 34 | await expect(dropdown).toBeAttached(); 35 | }); at /Users/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:32:50

Check failure on line 32 in projects/demo-playwright/tests/legacy/input-phone-international/input-phone-international.pw.spec.ts

View workflow job for this annotation

GitHub Actions / Playwright / macos-latest / 8 of 9

[webkit] › tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:24:13 › InputPhoneInternational › API page › Open dropdown if readonly=false

1) [webkit] › tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:24:13 › InputPhoneInternational › API page › Open dropdown if readonly=false Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── TimeoutError: locator.click: Timeout 10000ms exceeded. Call log: - waiting for locator('#demo-content').locator('tui-textfield').locator('.t-ipi-select') 30 | await expect(dropdown).not.toBeAttached(); 31 | > 32 | await inputPhoneInternational.select.click(); | ^ 33 | 34 | await expect(dropdown).toBeAttached(); 35 | }); at /Users/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:32:50

Check failure on line 32 in projects/demo-playwright/tests/legacy/input-phone-international/input-phone-international.pw.spec.ts

View workflow job for this annotation

GitHub Actions / Playwright / macos-latest / 8 of 9

[webkit] › tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:24:13 › InputPhoneInternational › API page › Open dropdown if readonly=false

1) [webkit] › tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:24:13 › InputPhoneInternational › API page › Open dropdown if readonly=false Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── TimeoutError: locator.click: Timeout 10000ms exceeded. Call log: - waiting for locator('#demo-content').locator('tui-textfield').locator('.t-ipi-select') 30 | await expect(dropdown).not.toBeAttached(); 31 | > 32 | await inputPhoneInternational.select.click(); | ^ 33 | 34 | await expect(dropdown).toBeAttached(); 35 | }); at /Users/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/legacy/input-phone-international/input-phone-international.pw.spec.ts:32:50

await expect(dropdown).toBeAttached();
});
Expand All @@ -33,7 +39,9 @@

await expect(dropdown).not.toBeAttached();

await select.click();
await expect(async () => {
await inputPhoneInternational.select.click();
}).rejects.toThrow();

await expect(dropdown).not.toBeAttached();
});
Expand Down
1 change: 1 addition & 0 deletions projects/demo-playwright/utils/page-objects/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export * from './input-date-time.po';
export * from './input-month.po';
export * from './input-month-range.po';
export * from './input-phone.po';
export * from './input-phone-international.po';
export * from './input-range.po';
export * from './input-slider.po';
export * from './input-tag.po';
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import type {Locator} from '@playwright/test';

import {TuiTextfieldWithDataListPO} from './textfield-with-data-list.po';

export class TuiInputPhoneInternationalPO extends TuiTextfieldWithDataListPO {
public select: Locator = this.host.locator('.t-ipi-select');
}
1 change: 1 addition & 0 deletions projects/demo/src/modules/app/pages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,7 @@ export const pages: DocRoutePages = [
title: 'Form',
keywords: 'форма, поле, кнопка, группировка, группа',
route: DemoRoute.FormLayout,
meta: {scheme: 'beaver', name: 'form'},
},
{
section: 'Components',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<input
formControlName="card"
tuiInputCard
tuiTextfield
[icon]="card"
(binChange)="onBinChange($event)"
/>
Expand All @@ -15,15 +14,13 @@
<input
formControlName="expire"
tuiInputExpire
tuiTextfield
/>
</tui-textfield>
<tui-textfield>
<label tuiLabel>CVC/CVV</label>
<input
formControlName="cvc"
tuiInputCVC
tuiTextfield
/>
</tui-textfield>
</section>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<input
icon=""
tuiInputCard
tuiTextfield
[(ngModel)]="card"
/>
<tui-thumbnail-card
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,20 @@
<input
formControlName="card"
tuiInputCard
tuiTextfield
/>
</tui-textfield>
<tui-textfield>
<label tuiLabel>Expire date</label>
<input
formControlName="expire"
tuiInputExpire
tuiTextfield
/>
</tui-textfield>
<tui-textfield>
<label tuiLabel>CVC/CVV</label>
<input
formControlName="cvc"
tuiInputCVC
tuiTextfield
/>
</tui-textfield>
</form>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
<label tuiLabel>Card number</label>
<input
tuiInputCard
tuiTextfield
[autocomplete]="autocomplete"
[disabled]="control.disabled"
[icon]="icon"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<tui-input-phone-international
[countries]="countries"
[(countryIsoCode)]="countryIsoCode"
[(ngModel)]="value"
/>
<tui-textfield>
<input
tuiInputPhoneInternational
[countries]="countries"
[(countryIsoCode)]="countryIsoCode"
[(ngModel)]="value"
/>
</tui-textfield>
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,15 @@ import {Component} from '@angular/core';
import {FormsModule} from '@angular/forms';
import {changeDetection} from '@demo/emulate/change-detection';
import {encapsulation} from '@demo/emulate/encapsulation';
import {TuiTextfield} from '@taiga-ui/core';
import {TuiInputPhoneInternational} from '@taiga-ui/experimental';
import type {TuiCountryIsoCode} from '@taiga-ui/i18n';
import {
TuiInputPhoneInternational,
tuiInputPhoneInternationalOptionsProvider,
} from '@taiga-ui/kit';
import {tuiInputPhoneInternationalOptionsProvider} from '@taiga-ui/kit';
import {defer} from 'rxjs';

@Component({
standalone: true,
imports: [FormsModule, TuiInputPhoneInternational],
imports: [FormsModule, TuiInputPhoneInternational, TuiTextfield],
templateUrl: './index.html',
encapsulation,
changeDetection,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
<tui-input-phone-international
[countries]="(countries | tuiSortCountries | async) || []"
[countrySearch]="true"
[(countryIsoCode)]="countryIsoCode"
[(ngModel)]="value"
>
Type your number
</tui-input-phone-international>
<tui-textfield>
<label tuiLabel>Phone number</label>
<input
tuiInputPhoneInternational
[countries]="(countries | tuiSortCountries | async) || []"
[countrySearch]="true"
[(countryIsoCode)]="countryIsoCode"
[(ngModel)]="value"
/>
</tui-textfield>
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ import {Component} from '@angular/core';
import {FormsModule} from '@angular/forms';
import {changeDetection} from '@demo/emulate/change-detection';
import {encapsulation} from '@demo/emulate/encapsulation';
import {TuiTextfield} from '@taiga-ui/core';
import {TuiInputPhoneInternational} from '@taiga-ui/experimental';
import type {TuiCountryIsoCode} from '@taiga-ui/i18n';
import {
TuiInputPhoneInternational,
tuiInputPhoneInternationalOptionsProvider,
TuiSortCountriesPipe,
} from '@taiga-ui/kit';
Expand All @@ -14,7 +15,13 @@ import {defer} from 'rxjs';

@Component({
standalone: true,
imports: [AsyncPipe, FormsModule, TuiInputPhoneInternational, TuiSortCountriesPipe],
imports: [
AsyncPipe,
FormsModule,
TuiInputPhoneInternational,
TuiSortCountriesPipe,
TuiTextfield,
],
templateUrl: './index.html',
encapsulation,
changeDetection,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<tui-textfield tuiDropdownMobile="Select country">
<label tuiLabel>Phone number</label>
<input
tuiInputPhoneInternational
[countries]="(countries | tuiSortCountries | async) || []"
[countrySearch]="true"
[(countryIsoCode)]="countryIsoCode"
[(ngModel)]="value"
/>
</tui-textfield>
Loading
Loading