Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): reset cached active period in tui-input-date-range #9946

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

splincode
Copy link
Member

Fixes #9860

@splincode splincode requested a review from a team as a code owner December 9, 2024 14:28
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 9, 2024 14:28
Copy link

lumberjack-bot bot commented Dec 9, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode changed the title fix(legacy): reset cached active period fix(legacy): reset cached active period in tui-input-date-range Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Visit the preview URL for this PR (updated for commit 1c0922d):

https://taiga-previews-demo--pr9946-splincode-fix-issues-9860-xzby0uuz.web.app

(expires Tue, 10 Dec 2024 14:49:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Dec 9, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
303.93KB (+27B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.19KB +10%
demo/browser/runtime.(hash).js
43.94KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +28B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.38MB (+267B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode force-pushed the splincode/fix/issues/9860 branch from 316e3e0 to 1c0922d Compare December 9, 2024 14:45
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (026d13c) to head (1c0922d).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9946   +/-   ##
=======================================
  Coverage   75.26%   75.26%           
=======================================
  Files        1249     1249           
  Lines       19607    19609    +2     
  Branches     2030     2054   +24     
=======================================
+ Hits        14757    14759    +2     
- Misses       4807     4808    +1     
+ Partials       43       42    -1     
Flag Coverage Δ
summary 75.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Playwright test results

failed  1 failed
passed  981 passed

Details

report  Open report ↗︎
stats  982 tests across 69 suites
duration  8 minutes, 59 seconds
commit  1c0922d

Failed tests

chromium › tests/demo/demo.pw.spec.ts › Demo › /components/input-date-range

@nsbarsukov nsbarsukov merged commit 1144fae into main Dec 12, 2024
26 of 27 checks passed
@nsbarsukov nsbarsukov deleted the splincode/fix/issues/9860 branch December 12, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - tui-input-date-range not update custom perion name by manual resetup model
3 participants