Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): Segmented fix shadow clipping in Safari #9931

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

vladimirpotekhin
Copy link
Member

Fixes #

@vladimirpotekhin vladimirpotekhin requested a review from a team as a code owner December 6, 2024 07:52
@vladimirpotekhin vladimirpotekhin requested review from MarsiBarsi, waterplea, nsbarsukov and mdlufy and removed request for a team December 6, 2024 07:52
Copy link

lumberjack-bot bot commented Dec 6, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Visit the preview URL for this PR (updated for commit 62099ed):

https://taiga-previews-demo--pr9931-fix-segmented-safari-demo-8s2koysv.web.app

(expires Sat, 07 Dec 2024 07:56:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Dec 6, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
303.88KB (+29B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
259.99KB +10%
demo/browser/runtime.(hash).js
43.84KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +29B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.33MB (+29B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Playwright test results

failed  1 failed
passed  974 passed

Details

report  Open report ↗︎
stats  975 tests across 69 suites
duration  9 minutes, 18 seconds
commit  62099ed

Failed tests

chromium › tests/demo/demo.pw.spec.ts › Demo › /charts/pie-chart

@vladimirpotekhin vladimirpotekhin merged commit c6c9c38 into main Dec 6, 2024
27 of 28 checks passed
@vladimirpotekhin vladimirpotekhin deleted the fix-segmented-safari branch December 6, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants