Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): removed redundant space #9916

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

40oleg
Copy link
Collaborator

@40oleg 40oleg commented Dec 4, 2024

Fixes #9700
Removed space at the start of button
image

@40oleg 40oleg requested a review from a team as a code owner December 4, 2024 14:10
@40oleg 40oleg requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 4, 2024 14:10
Copy link

lumberjack-bot bot commented Dec 4, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@40oleg 40oleg self-assigned this Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Visit the preview URL for this PR (updated for commit c1cb3fa):

https://taiga-previews-demo--pr9916-feature-extra-space-action-skxejcrz.web.app

(expires Thu, 05 Dec 2024 14:14:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Dec 4, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
303.79KB +10%
demo/browser/vendor.(hash).js
259.99KB +10%
demo/browser/runtime.(hash).js
43.78KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +3B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.32MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Playwright test results

passed  974 passed
flaky  1 flaky

Details

report  Open report ↗︎
stats  975 tests across 69 suites
duration  10 minutes, 57 seconds
commit  c1cb3fa

Flaky tests

chromium › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Closes dropdown on click on overlay

@splincode splincode merged commit e10d0eb into main Dec 4, 2024
28 checks passed
@splincode splincode deleted the feature/extra-space-action-bar branch December 4, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Extra space before link buttons text in ActionBar
3 participants