Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legacy): MultiSelect allow checkbox on the right side #9910

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

waterplea
Copy link
Collaborator

Fixes #

@waterplea waterplea requested a review from a team as a code owner December 4, 2024 11:51
@waterplea waterplea requested review from MarsiBarsi, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 4, 2024 11:51
Copy link

lumberjack-bot bot commented Dec 4, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Visit the preview URL for this PR (updated for commit 066a210):

https://taiga-previews-demo--pr9910-option-demo-kumq3rnw.web.app

(expires Thu, 05 Dec 2024 11:55:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Dec 4, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
303.79KB +10%
demo/browser/vendor.(hash).js
259.99KB +10%
demo/browser/runtime.(hash).js
43.78KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change -5B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.32MB (+159B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Playwright test results

failed  2 failed
passed  972 passed
flaky  1 flaky

Details

report  Open report ↗︎
stats  975 tests across 69 suites
duration  9 minutes, 6 seconds
commit  066a210

Failed tests

chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/icon
chromium › tests/legacy/multi-select/multi-select.pw.spec.ts › MultiSelect › Examples › multi-select with data list with label

Flaky tests

chromium › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Closes dropdown on click on overlay

@waterplea waterplea merged commit 8aa063b into main Dec 5, 2024
27 of 28 checks passed
@waterplea waterplea deleted the option branch December 5, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants