Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): MultiSelect fix pristine and updateOn: blur issues #9900

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

waterplea
Copy link
Collaborator

Fixes #6522

@waterplea waterplea requested a review from a team as a code owner December 3, 2024 15:13
@waterplea waterplea requested review from MarsiBarsi, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 3, 2024 15:13
Copy link

lumberjack-bot bot commented Dec 3, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Visit the preview URL for this PR (updated for commit 44ccd5e):

https://taiga-previews-demo--pr9900-multi-select-demo-alt6qe2e.web.app

(expires Wed, 04 Dec 2024 15:30:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Dec 3, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
303.88KB (+66B +0.02%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
259.97KB +10%
demo/browser/runtime.(hash).js
43.78KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +66B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.32MB (+66B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Playwright test results

passed  974 passed
flaky  1 flaky

Details

report  Open report ↗︎
stats  975 tests across 69 suites
duration  8 minutes, 45 seconds
commit  44ccd5e

Flaky tests

chromium › tests/demo/demo.pw.spec.ts › Demo › /components/multi-select

@waterplea waterplea merged commit d70edfb into main Dec 4, 2024
27 of 28 checks passed
@waterplea waterplea deleted the multi-select branch December 4, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - TuiMultiSelectGroup - control remains pristine after value set
3 participants