Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop ngStyle #9882

Merged
merged 2 commits into from
Dec 3, 2024
Merged

refactor: drop ngStyle #9882

merged 2 commits into from
Dec 3, 2024

Conversation

splincode
Copy link
Member

Fixes #9849

@splincode splincode requested a review from a team as a code owner December 2, 2024 11:34
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 2, 2024 11:34
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Dec 2, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode force-pushed the splincode/refactor/issues/9849 branch from 0bbab35 to 635c442 Compare December 2, 2024 11:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 6255b15):

https://taiga-previews-demo--pr9882-splincode-refactor-issues-udiynhwz.web.app

(expires Tue, 03 Dec 2024 11:49:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

@bundlemon BundleMon
Copy link

bundlemon bot commented Dec 2, 2024

BundleMon

Files updated (2)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 304.08KB (-18B -0.01%) +10%
✅ demo/browser/vendor.(hash).js
 259.97KB (-147B -0.06%) +10%
Unchanged files (3)
Status Path Size Limits
✅ demo/browser/runtime.(hash).js
 43.79KB +10%
✅ demo/browser/styles.(hash).css
 19.63KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change -164B -0.03%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.32MB (-176B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Playwright test results

passed  975 passed

Details

report  Open report ↗︎
stats  975 tests across 69 suites
duration  9 minutes, 7 seconds
commit  6255b15

@splincode splincode merged commit 15f2a46 into main Dec 3, 2024
27 checks passed
@splincode splincode deleted the splincode/refactor/issues/9849 branch December 3, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsbarsukov nsbarsukov nsbarsukov approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@splincode splincode

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🗂 - ngStyle and ngClass deprecated in the future, drop it
4 participants
@splincode @waterplea @nsbarsukov @taiga-family-bot