Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Dropdown fix initial width #9867

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix(core): Dropdown fix initial width #9867

merged 1 commit into from
Dec 2, 2024

Conversation

vladimirpotekhin
Copy link
Member

Fixes #9683

el.getBoundingClientRect() returns wrong initial width

taiga-ui/projects/core/services/position.service.ts

Line 25 in a28e79b

this.el.getBoundingClientRect(),

because of this left is not calculated correctly

@vladimirpotekhin vladimirpotekhin requested a review from a team as a code owner November 29, 2024 11:34
@vladimirpotekhin vladimirpotekhin requested review from MarsiBarsi, waterplea, nsbarsukov and mdlufy and removed request for a team November 29, 2024 11:34
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 29, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit df2e431):

https://taiga-previews-demo--pr9867-dropdown-fix-demo-t42k4rf8.web.app

(expires Sat, 30 Nov 2024 13:11:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 29, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 304.09KB (+11B 0%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 260.11KB +10%
✅ demo/browser/runtime.(hash).js
 43.79KB +10%
✅ demo/browser/styles.(hash).css
 19.63KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +11B 0%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.32MB (+11B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

Playwright test results

passed  975 passed

Details

report  Open report ↗︎
stats  975 tests across 69 suites
duration  8 minutes, 57 seconds
commit  df2e431

@splincode splincode merged commit 76d8d01 into main Dec 2, 2024
29 checks passed
@splincode splincode deleted the dropdown-fix branch December 2, 2024 11:15
@taiga-family-bot taiga-family-bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsbarsukov nsbarsukov nsbarsukov approved these changes

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@vladimirpotekhin vladimirpotekhin

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - Dropdown positioning bug
3 participants
@vladimirpotekhin @splincode @nsbarsukov