Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop redundant code for mobile #9548

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: drop redundant code for mobile #9548

merged 1 commit into from
Oct 21, 2024

Conversation

splincode
Copy link
Member

@splincode splincode commented Oct 18, 2024 •
edited
Loading

image

@splincode splincode requested a review from a team as a code owner October 18, 2024 15:46
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team October 18, 2024 15:46
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 18, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 454e72e):

https://taiga-previews--pr9548-splincode-drop-usele-hw97yqbf.web.app

(expires Sat, 19 Oct 2024 15:50:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 18, 2024

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 295.59KB (-41B -0.01%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 255.66KB +10%
✅ demo/browser/runtime.(hash).js
 43.23KB +10%
✅ demo/browser/styles.(hash).css
 19.31KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change -41B -0.01%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.16MB (-41B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@nsbarsukov nsbarsukov merged commit f7b7d4d into main Oct 21, 2024
28 checks passed
@nsbarsukov nsbarsukov deleted the splincode/drop-useless-code branch October 21, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlufy mdlufy mdlufy approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

Assignees

@splincode splincode

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@splincode @waterplea @mdlufy @nsbarsukov